Shaded slf4j-jdk14 to work with simba driver's shaded slf4j-api #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running Liquibase with the simba driver, we get a:
warning.
The way it is supposed to work is that you just have to add the slf4j binding jar you want. In our case, add the jar from https://mvnrepository.com/artifact/org.slf4j/slf4j-jdk14/ to your liquibase lib directory.
BUT: the datastax simba driver has shaded the slf4j dependency into a com.simba.cassandra.shaded.slf4j package and so the normal slf4j logic has been updated to look for a com/simba/cassandra/shaded/slf4j/impl/StaticLoggerBinder.class which is not valid in slf4j-jdk14 and so even with that jar file you get the binding error.
This PR shades the slf4j-jdk14 dependency into the liquibase-cassandra extension using the com.simba.cassandra.shaded.slf4j package so it gets found and the message goes away.