Implement support for hibernate timestamp columns with timezone #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-kleber-avelios
requested a review
from filipelautert
as a code owner
philipp-kleber-avelios
temporarily deployed
to
external
GitHub Actions
Inactive
|
I think it would be nice to at least add some basic unit test for this. Would you mind doing it? Thanks, |
philipp-kleber-avelios
requested a deployment
to
external
GitHub Actions
Waiting
|
Thank you for the feedback, I added a unit test and actually fixed a bug I noticed. |
philipp-kleber-avelios
requested a deployment
to
external
GitHub Actions
Waiting
MalloD12
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
LGTM
Thank you for adding a test for it and finding a bug.
A comment not related to this PR. I was thinking it would be nice to use Lombok in this extension. It would be useful to make a bit less verbose all the entity classes. I'll create a a separate ticket for it.
Again, thank you for your contributions.
Daniel.
MalloD12
reviewed
Dec 11, 2024
|
BTW, just to let you know, I created this enhancement #735 I mentioned I was going to create. Thanks, |
philipp-kleber-avelios
requested a deployment
to
external
GitHub Actions
Waiting
filipelautert
approved these changes
Dec 12, 2024
rberezen
approved these changes
Dec 13, 2024
tati-qalified
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 5 or 6, Hibernate started adding the
with time zonesuffix to columns of certain types.This PR aims to correctly transfer the
with time zonesuffix from Hibernate to the corresponding Liquibase formatwith timezone.