Skip to content

Commit

Permalink
DAT-14478. replaced AdvancedHarnessSuiteTest with LiquibaseHarnessSui…
Browse files Browse the repository at this point in the history
…teTest as a default test suite. Fixes in test data for mssql:gcp. (#539)

* DAT-14478. replaced AdvancedHarnessSuiteTest with LiquibaseHarnessSuiteTest as a default test suite

* DAT-14478. refactored AdvancedHarnessSuiteTest to use older version of advanced test

* DAT-14478. reverted last commit

* DAT-14478. removed unused imports

* DAT-14478. changed init.sql for gcp mssql instance

* DAT-14478. changed init.sql for gcp mssql instance

* DAT-14478. fixed test data for gcp mssql harness suite

* DAT-14478. renamed mssql:2019 to mssql:gcp

* DAT-14478. small fix

* DAT-14478. small fix

* DAT-14478. fix in expeted sql for mssql gcp

* DAT-14478. fix in expeted sql for mssql gcp
  • Loading branch information
PavloTytarchuk authored and jandroav committed Apr 27, 2023
1 parent fafb371 commit 7c471f7
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/gcp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ on:
databases:
description: Databases to start up. Comma separated list of "name:version"
required: true
default: "[\"postgresql:11\",\"postgresql:12\",\"postgresql:13\",\"postgresql:14\",\"mysql:gcp\",\"mssql:2019\"]"
default: "[\"postgresql:11\",\"postgresql:12\",\"postgresql:13\",\"postgresql:14\",\"mysql:gcp\",\"mssql:gcp\"]"

jobs:
setup:
name: Setup
runs-on: ubuntu-latest
outputs:
databases: ${{ github.event.inputs.databases || '["postgresql:11","postgresql:12","postgresql:13","postgresql:14","mysql:gcp","mssql:2019"]' }}
databases: ${{ github.event.inputs.databases || '["postgresql:11","postgresql:12","postgresql:13","postgresql:14","mysql:gcp","mssql:gcp"]' }}
testClasses: ${{ inputs.testClasses || 'LiquibaseHarnessSuiteTest' }}
steps:
- name: Checkout
Expand Down Expand Up @@ -120,7 +120,7 @@ jobs:
if: ${{ steps.setup.outputs.databasePlatform == 'mssql' }}
with:
operation: "update"
classpath: "src/test/resources/init-changelogs/aws"
classpath: "src/test/resources/init-changelogs/gcp"
changeLogFile: "mssql.sql"
username: "${{secrets.TH_DB_ADMIN}}"
password: "${{secrets.TH_DB_PASSWD}}"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
IF EXISTS( SELECT extended_properties.value FROM SYS.EXTENDED_PROPERTIES WHERE major_id = OBJECT_ID('lbuser.authors') AND name = N'MS_DESCRIPTION' AND minor_id = ( SELECT column_id FROM SYS.COLUMNS WHERE name = 'id' AND object_id = OBJECT_ID('lbuser.authors')) ) BEGIN EXEC sys.sp_updateextendedproperty @name = N'MS_Description' , @value = N'A Test Column Remark' , @level0type = N'SCHEMA' , @level0name = N'lbuser' , @level1type = N'TABLE' , @level1name = N'authors' , @level2type = N'COLUMN' , @level2name = N'id' END ELSE BEGIN EXEC sys.sp_addextendedproperty @name = N'MS_Description' , @value = N'A Test Column Remark' , @level0type = N'SCHEMA' , @level0name = N'lbuser' , @level1type = N'TABLE' , @level1name = N'authors' , @level2type = N'COLUMN' , @level2name = N'id' END
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
IF EXISTS( SELECT extended_properties.value FROM SYS.EXTENDED_PROPERTIES WHERE major_id = OBJECT_ID('lbuser.authors') AND name = N'MS_DESCRIPTION' AND minor_id = 0 ) BEGIN EXEC sys.sp_updateextendedproperty @name = N'MS_Description' , @value = N'A Test Remark' , @level0type = N'SCHEMA' , @level0name = N'lbuser' , @level1type = N'TABLE' , @level1name = N'authors' END ELSE BEGIN EXEC sys.sp_addextendedproperty @name = N'MS_Description' , @value = N'A Test Remark' , @level0type = N'SCHEMA' , @level0name = N'lbuser' , @level1type = N'TABLE' , @level1name = N'authors' END
2 changes: 1 addition & 1 deletion src/test/resources/harness-config-cloud.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ databasesUnderTest:

- name: mssql
prefix: gcp
version: 2019
version: gcp
url: DBENDPOINT
username: USERNAME
password: PASSWORD
Expand Down

0 comments on commit 7c471f7

Please sign in to comment.