DAT-14267: add liquibase-github-action to update mssql database

[jandroav]

feat(mssql.sql): add liquibase changeset to add lbuser and grant db_owner role to it
DAT-14267

[jandroav]

I am getting:

Unexpected error running Liquibase: Cannot invoke "Object.getClass()" because "unexpectedObject" is null

here: https://github.com/liquibase/liquibase-test-harness/actions/runs/4666624792/jobs/8261428473

It is failing in the drop-all step, before the new code. Any idea about what is happening? @yodzhubeiskyi Could you please take a look when you have time?

[jnewton03]

@jandroav we should try to move away from the all-in-one Github action since it's deprecated

https://github.com/liquibase-github-actions/update is what we want to use instead

[jandroav]

@jnewton03 Changed and run a build with logLevel: INFO. It seems liquibase can perform the drop but it fails at the end: https://github.com/liquibase/liquibase-test-harness/actions/runs/4675293365/jobs/8280278955

Also added failOnError:false in the changelog to avoid the following error when the script has already been executed:

Unexpected error running Liquibase: Migration failed for changeset src/test/resources/init-changelogs/gcp/mssql.sql::1::liquibase:
     Reason: liquibase.exception.DatabaseException: User, group, or role '***' already exists in the current database. [Failed SQL: (15023) EXEC sp_adduser '***']

[jnewton03]

@jandroav would a cleaner solution be to check if the user already exists first? Something like:

USE lbcat;

IF NOT EXISTS (SELECT * FROM sys.sysusers WHERE name = 'lbuser')
BEGIN
    EXEC sp_adduser 'lbuser';
END

IF NOT EXISTS (SELECT 1 FROM sys.database_principals WHERE name = 'lbuser' AND type_desc = 'DATABASE_ROLE' AND is_fixed_role = 0)
BEGIN
    EXEC sp_addrolemember 'db_owner', 'lbuser';
END

[KushnirykOleh]

@jandroav , after Pavlo's PR mssql on gcp seems to be working fine, i'm not sure if we need recreating user for test-harness tests

[jandroav]

It seems not necessary and I can see it is working fine now. thanks!

[jnewton03]

so should this pr be closed and ticket moved to done?

[jandroav]

After fixing branch conflicts we need to merge our already tested change:

USE lbcat;

IF NOT EXISTS (SELECT * FROM sys.sysusers WHERE name = 'lbuser')
BEGIN
    EXEC sp_adduser 'lbuser';
END

IF NOT EXISTS (SELECT 1 FROM sys.database_principals WHERE name = 'lbuser' AND type_desc = 'DATABASE_ROLE' AND is_fixed_role = 0)
BEGIN
    EXEC sp_addrolemember 'db_owner', 'lbuser';
END

@PavloTytarchuk I could see GCP mssql tests are failing again with the same issue https://github.com/liquibase/liquibase-test-harness/actions/runs/4816521824/jobs/8576252537

[KushnirykOleh]

@jandroav looking at this issue with @PavloTytarchuk we discovered most likely that dropAll doesn't work because of different schemas dbo (used in init script) and lbuser used in tests.
So recreating user won't resolve the issue.
We will try to figure out correct approach for gcp mssql as such config seems to be working differently that on AWS