Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAT-17032-17033 Setup Azure Postgres 15/16 #748

Merged
merged 9 commits into from
Mar 12, 2024
Merged

DAT-17032-17033 Setup Azure Postgres 15/16 #748

merged 9 commits into from
Mar 12, 2024

Conversation

jandroav
Copy link
Contributor

@jandroav jandroav commented Mar 6, 2024

fix(azure.yml): remove 'postgresql:azure' from default databases list… as it is not supported

feat(azure.yml): update job to add support for flexible PostgreSQL server testing
feat(azure.yml): update job to dynamically select PostgreSQL version for testing

… as it is not supported

feat(azure.yml): update job to add support for flexible PostgreSQL server testing
feat(azure.yml): update job to dynamically select PostgreSQL version for testing
Copy link
Contributor

@PavloTytarchuk PavloTytarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @jandroav! I've tried to run this workflow on GHA, and it fails because of this line:
url: "${{ secrets['TH_AZURE_POSTGRESQL_FLEXIBLE_SERVER_' + matrix.version + '_URL'] }}" github doesn't like the '+' symbols.

…FLEXIBLE_SERVER_URL to dynamically set PostgreSQL Flexible Server URL based on matrix version

fix(azure.yml): update references to PostgreSQL Flexible Server URL secrets to use the newly introduced environment variable TH_AZURE_POSTGRESQL_FLEXIBLE_SERVER_URL for consistency and flexibility
…b to run only if 'postgresql:flexible' is in the inputs.databases array

refactor(azure.yml): remove unnecessary setup step for configuring test as it is no longer needed due to the updated condition for the job to run
…fore postgresql-flexible-test job

chore(azure.yml): remove redundant 'if' conditions for liquibase actions to simplify workflow logic
chore(azure.yml): remove unnecessary 'if' condition for test run step to streamline workflow execution
@jandroav
Copy link
Contributor Author

jandroav commented Mar 6, 2024

Hello, @jandroav! I've tried to run this workflow on GHA, and it fails because of this line: url: "${{ secrets['TH_AZURE_POSTGRESQL_FLEXIBLE_SERVER_' + matrix.version + '_URL'] }}" github doesn't like the '+' symbols.

Fixed -> https://github.com/liquibase/liquibase-test-harness/actions/runs/8171831543
It won't work until the PR to create the infra is merged @PavloTytarchuk

@jandroav jandroav requested a review from PavloTytarchuk March 6, 2024 12:13
…l:azure' and 'postgresql:flexible' for more comprehensive database support

feat(azure.yml): add support for Azure PostgreSQL Single Server in database setup and testing for improved database compatibility and testing coverage
…t to include

support for Azure PostgreSQL databases in the workflow outputs
@jandroav
Copy link
Contributor Author

@PavloTytarchuk @jnewton03 Added changes to keep azure postgresql single server version 11 as per this comment: https://datical.atlassian.net/browse/DAT-17033?focusedCommentId=138247

Copy link
Contributor

@PavloTytarchuk PavloTytarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@jandroav jandroav merged commit 48e6036 into main Mar 12, 2024
58 of 60 checks passed
@jandroav jandroav deleted the DAT-17032-17033 branch March 12, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants