Merge pull request #3 from liquibase/fix-hidden-commands

Do not output hidden commands.
liquibase · Aug 8, 2023 · 691f49a · 691f49a
2 parents 2272491 + 1839ec7
commit 691f49a
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/src/main/java/liquibase/command/GenerateProtobufCommandStep.java b/src/main/java/liquibase/command/GenerateProtobufCommandStep.java
@@ -2,6 +2,7 @@
 
 import liquibase.configuration.ConfigurationDefinition;
 import liquibase.configuration.LiquibaseConfiguration;
+import liquibase.exception.UnexpectedLiquibaseException;
 import liquibase.util.StringUtil;
 
 import java.io.BufferedWriter;
@@ -42,13 +43,17 @@ public void run(CommandResultsBuilder resultsBuilder) throws Exception {
 
  writeGlobalToFile(outputDir);
 
- if (targetCommand != "") {
- writeCommandToFile(getCommand(targetCommand), outputDir);
+ if (StringUtil.isNotEmpty(targetCommand)) {
+ CommandDefinition command = getCommand(targetCommand);
+ if (command.getHidden()) {
+ throw new UnexpectedLiquibaseException("Command " + targetCommand + " cannot be generated as it is defined as a 'hidden' command by Liquibase");
+ }
+ writeCommandToFile(command, outputDir);
  } else {
  // Generate protobuf for all commands
  for (CommandDefinition commandDefinition : getCommands()) {
- //Don't generate protobuf for generateProtobuf command step
- if (commandDefinition.getName() == COMMAND_NAME) {
+ //Don't generate protobuf for generateProtobuf command step or hidden commands
+ if (commandDefinition.getName() == COMMAND_NAME || commandDefinition.getHidden()) {
  continue;
  }
  writeCommandToFile(commandDefinition, outputDir);