Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests and integration testing setup (PE-1115) #295

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

juliaaschmidt
Copy link
Contributor

@juliaaschmidt juliaaschmidt commented Sep 25, 2024

Integration Tests + Integration Testing Deployment Setup PE-1115

  • adds a new complete Integration Test Deployment Setup (incl. TUPProxy and Firewall) DeploymentFixture.sol .
  • refactors repeatedly used helper functions from previous unit tests into a separate helpers file utils/RiverTestHelper.sol
  • adds new helper functions to support the Integration Testing utils/IntegrationTestHelpers.sol
  • adds separate events files to import expected events into tests rather than importing or declaring inline utils/events/
  • adds 3 integration test files
    • Deployment Deployment.t.sol
    • Deposit DepositIntegration.t.sol
    • Oracle OracleIntegration.t.sol
    • Withdraw WithdrawIntegration.t.sol
  • refactors River.1.t.sol and OracleManager.1.t.sol to inherit from RivherTestHelper instead of code duplication.
  • refactored the old deployment setup (RiverV1TestBase contract) used for unit tests inside River and Oracle to RiverUnitTestBase.sol to avoid code duplication and import common standards
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you assigned this PR to yourself?
  • Have you added at least 1 reviewer?
  • Have you updated the official documentation?
  • Have you added sufficient documentation in your code?
  • Have you added relevant tests to the official test suite?

Pull Request Type

  • 💫 New Feature (Breaking Change)
  • 💫 New Feature (Non-breaking Change)
  • 🛠️ Bug fix (Non-breaking Change: Fixes an issue)
  • 🕹️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)

Breaking changes (if applicable)

Testing

  • Have you tested this code with the official test suite?
  • Have you tested this code manually?

Manual tests (if applicable)

Additional comments

@juliaaschmidt juliaaschmidt changed the title Julia/feat/integration tests Add integration tests and integration testing setup Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (968a3a3) to head (35d8aa1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   95.03%   95.20%   +0.16%     
==========================================
  Files          75       75              
  Lines        1773     1773              
  Branches      235      235              
==========================================
+ Hits         1685     1688       +3     
+ Misses         29       27       -2     
+ Partials       59       58       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@juliaaschmidt juliaaschmidt changed the title Add integration tests and integration testing setup Add integration tests and integration testing setup (PE-1115) Sep 26, 2024
@juliaaschmidt juliaaschmidt marked this pull request as ready for review October 1, 2024 09:46
@mischat
Copy link
Member

mischat commented Nov 25, 2024

@juliaaschmidt do we still want to get this PR merged in ? It is still relevant ? If so, could you please fix the conflict, and lets try and get it merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants