Skip to content

Merge 2021.11.05-zane@liquid-labs.com-support_sourcing_responsibility_for to master #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanerock merged 5 commits into from
Jan 27, 2022
Merged

Merge 2021.11.05-zane@liquid-labs.com-support_sourcing_responsibility_for to master #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2d4eb5e
changelog update
zanerock Jan 25, 2022
d3d9b13
update catalyst-scripts
zanerock Jan 25, 2022
bbd74e6
update emals for long TLDs; add long TLD tests
zanerock Jan 25, 2022
2e8422e
fix 'npm audit' issue
zanerock Jan 27, 2022
ac6960f
changelog finalization (by liq) [no ci]
zanerock Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .meta/changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
- startTimestamp: 2022-01-25T17:03:56.713Z
startEpochMillis: 1643130236713
issues:
- https://github.com/Liquid-Labs/liq-core/issues/33
- https://github.com/Liquid-Labs/liq-core/issues/36
- https://github.com/Liquid-Labs/liq-audits/issues/1
branch: 2021.11.05-zane@liquid-labs.com-support_sourcing_responsibility_for
branchFrom: 53b413d599fb218ff43f56a36dc52503995da873
workInitiator: zane@liquid-labs.com
branchInitiator: zane@liquid-labs.com
involvedProjects:
- "@liquid-labs/liq-core"
- "@liquid-labs/liq-audits"
- "@liquid-labs/orgs-model"
- "@liquid-labs/liq-vendors"
- "@liquid-labs/policies-model"
- "@liquid-labs/regex-repo"
changeNotes:
- Support sourcing responsibility for evidence
securityNotes: []
drpBcpNotes: []
backoutNotes: []
contributors:
- Zane Rockenbaugh <zane@liquid-labs.com>
6 changes: 4 additions & 2 deletions js/test-data/emails.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@ export const goodEmails = [
'foo@bar.org',
'foo@bar.xqc',
'foo@baz.bar.xqc',
'foo-_18+Z.t%c@Bar-teg38w.co'
'foo-_18+Z.t%c@Bar-teg38w.co',
'foo@some.reallylongtld'
]

export const badEmails = [
'foo.bar.com',
'foo@bar.c',
'foo@.com'
'foo@.com',
'foo@some.really-long-tld-with-dashes'
]
const badDomainChars = ['_', '@', '+', '%']
badDomainChars.forEach((c) => badEmails.push(`foo@bar${c}baz.com`))
4 changes: 3 additions & 1 deletion js/test-data/urls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ export const goodUrls = [
`http://-.~_!$&'()*+,;=:%40:80%2f::::::@example.com`,
'http://1337.net',
'http://a.b-c.de',
'http://223.255.255.254'
'http://223.255.255.254',
'http://some.reallylongtld'
]

export const badUrls = [
Expand Down Expand Up @@ -76,4 +77,5 @@ export const badUrls = [
'http://.www.foo.bar/',
'http://www.foo.bar./',
'http://.www.foo.bar./',
'http://some.really-long-tld-with-dashes'
]
3 changes: 2 additions & 1 deletion js/web.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ export const url =
+ '(?:\\.(?:1?\\d{1,2}|2[0-4]\\d|25[0-5])){2}'
+ '(?:\\.(?:[1-9]\\d?|1\\d\\d|2[0-4]\\d|25[0-4]))|(?:(?:[a-z\\u00a1-\\uffff0-9]+-?)*[a-z\\u00a1-\\uffff0-9]+)(?:\\.(?:[a-z\\u00a1-\\uffff0-9]+-?)*[a-z\\u00a1-\\uffff0-9]+)*(?:\\.(?:[a-z\\u00a1-\\uffff]{2,})))|localhost)(?::\\d{2,5})?(?:(/|\\?|#)[^\\s]*)?$', 'i')

export const email = /^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/i
// TODO: properly support all domain names https://github.com/liquid-labs/regex-repo/issues/3
export const email = /^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,}$/i
Loading