Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples #58

Closed
wants to merge 2 commits into from
Closed

Examples #58

wants to merge 2 commits into from

Conversation

mgax
Copy link
Member

@mgax mgax commented Jul 22, 2019

@mgax mgax requested a review from gabriel-v July 22, 2019 07:19
Copy link
Member

@gabriel-v gabriel-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be possible to have 2 override confs?

  • local-registry.conf to change the exec line
  • gomaxprocs.conf to change that env

Some users will want only the GOMAXPROCS fix, and others only the local registry. Let's treat them separately

@@ -31,6 +33,10 @@ if [ ! -z $rmdocker ]; then (
) fi
) fi

if [ ! -z $nuke ]; then (
sudo rm -rf var/consul var/nomad var/supervisor var/vault-secrets.ini
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer git clean -Xdf var so we don't have to update this list.

@@ -0,0 +1,5 @@
# /etc/systemd/system/docker.service.d/override.conf
[Service]
Environment="GOMAXPROCS=8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme section with when/why this is needed?

[Service]
Environment="GOMAXPROCS=8"
ExecStart=
ExecStart=/usr/bin/dockerd -H fd:// --insecure-registry 10.66.60.1:6665 --registry-mirror http://10.66.60.1:6665
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port is 9991 now.

@mgax mgax closed this Aug 23, 2022
@mgax mgax deleted the examples branch August 23, 2022 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants