Skip to content

auth init redux #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sgsullivan merged 3 commits into from
Jun 23, 2020
Merged

auth init redux #43

sgsullivan merged 3 commits into from
Jun 23, 2020

Conversation

@sgsullivan
Copy link
Contributor

@sgsullivan sgsullivan commented Jun 20, 2020

This PR supercedes #42

It fixes the same issue, but also moves the interactive user input portions of auth init to a new module, and should also have better Windows support.

@sgsullivan sgsullivan requested review from dwburke and jvandellen June 20, 2020 03:54
@sgsullivan sgsullivan changed the title move auth init to go-prompt auth init redux Jun 20, 2020
@sgsullivan sgsullivan requested a review from ctriv June 20, 2020 04:06
jvandellen
jvandellen approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@jvandellen jvandellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sgsullivan sgsullivan merged commit 334f2fa into master Jun 23, 2020
@sgsullivan sgsullivan deleted the auth-init-redux branch June 23, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvandellen jvandellen jvandellen approved these changes

@dwburke dwburke Awaiting requested review from dwburke

@ctriv ctriv Awaiting requested review from ctriv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sgsullivan @jvandellen