Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed package from not publishing template root files (#6) #25

Merged
merged 1 commit into from
Jul 18, 2020

Conversation

alemagio
Copy link
Contributor

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Related Issue

Motivation and Context

Using files directly into the template/package.json file prevented some template files from being published.

How Has This Been Tested?

image
This is how the template folder looks like after running npm pack in the root folder of the create-node-lib project.

image
This is what will be inside a new project created using create-node-lib and running npm pack in its root folder.

Screenshots (if appropriate):

Checklist:

  • I have updated the documentation (if required).
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I added a picture of a cute animal cause it's fun

@lirantal lirantal self-requested a review July 18, 2020 10:55
@lirantal lirantal added the bug label Jul 18, 2020
@lirantal lirantal merged commit bcffacd into lirantal:master Jul 18, 2020
@lirantal
Copy link
Owner

thanks!

@lirantal
Copy link
Owner

🎉 This PR is included in version 2.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants