Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email is entered in application email button due to absez #30

Closed
yusufJinadu opened this issue Apr 21, 2020 · 4 comments · Fixed by #55
Closed

Email is entered in application email button due to absez #30

yusufJinadu opened this issue Apr 21, 2020 · 4 comments · Fixed by #55
Assignees
Labels
bug Something isn't working released

Comments

@yusufJinadu
Copy link

Please describe the problem you are trying to solve.
My page has an email input, with 'input[type="email"]'. Immediately the sign in button is clicked, the plugin does not wait till the browser redirects rather, it starts entering the the email on my page's email field

Describe the solution you'd like
Email is typed only when clicking on login selector has completely redirected
Please describe the desired behavior.

Describe alternatives you've considered
An option to add a delay before entering the email, so that the page redirects before email is typed
Please describe alternative solutions or features you have considered.

@lirantal
Copy link
Owner

I'm not sure what is the issue. Can you describe or show a video of what happens? Why do you need that delay? This plugin waits for cookies to be available and then uses them to apply to Cypress.

Anyway, we do have delay support added, check the README for loginSelectorDelay

@mpoehler
Copy link
Contributor

mpoehler commented Sep 3, 2020

I have just seen the problem for myself. In typeUsername() the username is written into the email field of the application, if on the page with the login buttons there is also an input from type email.

Video: https://drive.google.com/file/d/16uyiXG-WpPTO4VlqwjU8j5WgXSxxkVrv/view?usp=sharing

I think I already have a solution for this... probably it is enough to make the selector a bit more precise

@lirantal
Copy link
Owner

lirantal commented Sep 4, 2020

Ahh the video makes a lot of sense, thanks for that! :-)
Let's discuss further on the PR

@lirantal lirantal added the bug Something isn't working label Sep 4, 2020
mpoehler added a commit to mpoehler/cypress-social-logins that referenced this issue Sep 5, 2020
See Video in Issue lirantal#30 for explaination. I just made the selector a little more precise.

closes lirantal#30
lirantal pushed a commit that referenced this issue Sep 5, 2020
See Video in Issue #30 for explaination. I just made the selector a little more precise.
Closes #30
@lirantal
Copy link
Owner

lirantal commented Sep 5, 2020

🎉 This issue has been resolved in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
3 participants