fix: dont die on undefined. signed, a js dev

lirantal · Nov 6, 2021 · 24ff604 · 24ff604
1 parent f11b0ef
commit 24ff604
Showing 1 changed file with 34 additions and 30 deletions.
diff --git a/src/rules/no-bidi.ts b/src/rules/no-bidi.ts
@@ -4,37 +4,41 @@ export function noBidi(context) {
  return {
  onCodePathStart: function (codePath, node) {
  // at the start of analyzing a code path
- node.tokens.forEach((tokenObject) => {
- if (
- tokenObject.value &&
- hasTrojanSource({ sourceText: tokenObject.value })
- ) {
- context.report({
- node: node,
- data: {
- text: tokenObject.value.toString("utf-8"),
- },
- message:
- "Detected potential trojan source attack with unicode bidi introduced in this code: '{{text}}'.",
- });
- }
- });
+ if (node.tokens && Array.isArray(node.tokens)) {
+ node.tokens.forEach((tokenObject) => {
+ if (
+ tokenObject.value &&
+ hasTrojanSource({ sourceText: tokenObject.value })
+ ) {
+ context.report({
+ node: node,
+ data: {
+ text: tokenObject.value.toString("utf-8"),
+ },
+ message:
+ "Detected potential trojan source attack with unicode bidi introduced in this code: '{{text}}'.",
+ });
+ }
+ });
+ }
 
- node.comments.forEach((tokenObject) => {
- if (
- tokenObject.value &&
- hasTrojanSource({ sourceText: tokenObject.value })
- ) {
- context.report({
- node: node,
- data: {
- text: tokenObject.value.toString("utf-8"),
- },
- message:
- "Detected potential trojan source attack with unicode bidi introduced in this comment: '{{text}}'.",
- });
- }
- });
+ if (node.comments && Array.isArray(node.comments)) {
+ node.comments.forEach((tokenObject) => {
+ if (
+ tokenObject.value &&
+ hasTrojanSource({ sourceText: tokenObject.value })
+ ) {
+ context.report({
+ node: node,
+ data: {
+ text: tokenObject.value.toString("utf-8"),
+ },
+ message:
+ "Detected potential trojan source attack with unicode bidi introduced in this comment: '{{text}}'.",
+ });
+ }
+ });
+ }
  },
  };
 }