release: v1.8.3

liriliri · Oct 17, 2024 · 097457c · 097457c
1 parent 3cae0ed
commit 097457c
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 4 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -5,9 +5,7 @@
     "node": true
   },
   "parser": "@typescript-eslint/parser",
-  "plugins": [
-    "@typescript-eslint"
-  ],
+  "plugins": ["@typescript-eslint"],
   "extends": [
     "eslint:recommended",
     "plugin:@typescript-eslint/recommended",

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.8.3 (17 Oct 2024)
+
+* fix: ignore special ws connection
+
 ## 1.8.2 (15 Oct 2024)
 
 * fix: cache network requests before enable

diff --git a/devtools/network.js b/devtools/network.js
@@ -32,6 +32,18 @@ function testWs() {
   setTimeout(() => {
     ws.close()
   }, 1000)
+
+  const wsIgnore = new WebSocket(
+    'wss://echo.websocket.org?__chobitsu-hide__=true'
+  )
+
+  wsIgnore.onopen = function () {
+    wsIgnore.send(text)
+    wsIgnore.send(enc.encode(text))
+  }
+  setTimeout(() => {
+    wsIgnore.close()
+  }, 1000)
 }
 
 testFetch()

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "chobitsu",
-  "version": "1.8.2",
+  "version": "1.8.3",
   "description": "Chrome devtools protocol JavaScript implementation",
   "main": "dist/chobitsu.js",
   "exports": {

diff --git a/src/domains/Network.ts b/src/domains/Network.ts
@@ -189,6 +189,11 @@ function enableWebSocket() {
   const origWebSocket = window.WebSocket
   function WebSocket(url: string, protocols?: string | string[]) {
     const ws = new origWebSocket(url, protocols)
+
+    if (!isValidUrl(url)) {
+      return ws
+    }
+
     const requestId = createId()
 
     trigger('Network.webSocketCreated', {

diff --git a/webpack.config.js b/webpack.config.js
@@ -17,6 +17,7 @@ module.exports = {
   devServer: {
     static: {
       directory: path.join(__dirname, 'devtools'),
+      watch: false,
     },
     port: 8080,
   },