release(modal): v1.2.3

liriliri · May 10, 2024 · 2e5b713 · 2e5b713
1 parent d2b4725
commit 2e5b713
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 3 deletions.
diff --git a/index.json b/index.json
@@ -200,7 +200,7 @@
   "modal": {
     "react": true,
     "icon": true,
-    "version": "1.2.2",
+    "version": "1.2.3",
     "style": true,
     "test": true,
     "install": false,

diff --git a/src/modal/CHANGELOG.md b/src/modal/CHANGELOG.md
@@ -1,4 +1,8 @@
-## 1.2.2 (22 Apr 2023)
+## 1.2.3 (10 May 2024)
+
+* fix: react onClose unable to update
+
+## 1.2.2 (22 Apr 2024)
 
 * fix: title shrinked
 

diff --git a/src/modal/package.json b/src/modal/package.json
@@ -1,6 +1,6 @@
 {
   "name": "modal",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "Create modal dialogs",
   "luna": {
     "react": true,

diff --git a/src/modal/react.tsx b/src/modal/react.tsx
@@ -54,6 +54,14 @@ const LunaModal: FC<PropsWithChildren<IModalProps>> = (props) => {
     }, [props[key]])
   })
 
+  useEffect(() => {
+    if (modal.current) {
+      modal.current.hide = function () {
+        props.onClose && props.onClose()
+      }
+    }
+  }, [props.onClose])
+
   useEffect(() => {
     if (modal.current) {
       if (props.visible) {