Skip to content

Commit

Permalink
In ClientConductor, call forceCloseResources before setting conductor…
Browse files Browse the repository at this point in the history
…Running to false. ClientConductor.Close waits for conductorRunning to be set to false before continuing, so if it is allowed to continue before forceCloseResources, Aeron could be closed and the underlying counters memory buffer could get garbage collected away.
  • Loading branch information
peterTalos committed Jan 23, 2023
1 parent 6b5fe39 commit 56c58ae
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions aeron/clientconductor.go
Original file line number Diff line number Diff line change
Expand Up @@ -310,9 +310,8 @@ func (cc *ClientConductor) run(idleStrategy idlestrategy.Idler) {
cc.onError(errors.New(errStr))
cc.running.Set(false)
}
cc.conductorRunning.Set(false)

cc.forceCloseResources()
cc.conductorRunning.Set(false)

logger.Infof("ClientConductor done")
}()
Expand Down

0 comments on commit 56c58ae

Please sign in to comment.