Update method names in GroupAdapter and add javadoc to better document what they do #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| /** | ||
| * This returns the total number of items contained in the top level group at the passed index | ||
| */ | ||
| public int getItemCount(int groupIndex) { |
There was a problem hiding this comment.
This could be getItemCountForGroup()
There was a problem hiding this comment.
good catch, changed
…t what they do - BREAKING: original `getGroup(position)` has been replaced with `getGroupAtAdapterPosition(position)`. getGroup(position) will now return a top level group - BREAKING: `removeGroup(index)` has been renamed to `removeGroupAtAdapterPosition(position)` to reflect what it was actually doing - BREAKING: `getItemCount` renamed to `getItemCountForGroup`
ValCanBuild
force-pushed
the
feature/#295-better-method-naming
branch
from
2bd2430 to
0df7356
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getGroup(position)has been replaced withgetGroupAtAdapterPosition(position). getGroup(position) will now return a top level groupremoveGroup(index)has been renamed toremoveGroupAtAdapterPosition(position)to reflect what it was actually doing