Bring back old pre-2.7.0 methods and mark them as deprecated. #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitav13
reviewed
Oct 22, 2019
| @@ -312,6 +312,15 @@ public int getItemCountForGroup(int groupIndex) { | |||
| return groups.get(groupIndex).getItemCount(); | |||
| } | |||
|
|
|||
| /** | |||
| * This returns the total number of items contained in the top level group at the passed index | |||
| * @deprecated This method has been deprecated in favour of {@link #getItemCountForGroup(int)}. Please use that method instead. | |||
There was a problem hiding this comment.
It would have been awesome if we had this file in Kotlin - we could have used the @ReplaceWith annotation like described here: https://hackernoon.com/how-kotlins-deprecated-relieves-pain-of-colossal-refactoring-8577545aaed.
This should work for now though!
There was a problem hiding this comment.
Yes it would have indeed. I have explored converting the library to Kotlin but the benefit of a direct conversion isn't that great over just keeping it in Java. It'll be worth it more if we decide to do a larger API overhaul that leverages Kotlin features a lot more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.