[Interp] Restore cwd when skipping processes with unavailable cwd (cl…

…oses #147 by Stavros Ntentos @stdedos).
liske · Apr 13, 2019 · 8eca39d · 8eca39d
1 parent 1a9f11c
commit 8eca39d
Show file tree

Hide file tree

Showing 3 changed files with 45 additions and 3 deletions.
diff --git a/perl/lib/NeedRestart/Interp/Perl.pm b/perl/lib/NeedRestart/Interp/Perl.pm
@@ -54,11 +54,18 @@ sub source {
     my $ptable = nr_ptable_pid($pid);
     unless($ptable->{cwd}) {
 	print STDERR "$LOGPREF #$pid: could not get current working directory, skipping\n" if($self->{debug});
-	return ();
+	return undef;
     }
     my $cwd = getcwd();
     chdir("/proc/$pid/root/$ptable->{cwd}");
 
+    # skip the process if the cwd is unreachable (i.e. due to mnt ns)
+    unless(getcwd()) {
+	chdir($cwd);
+	print STDERR "$LOGPREF #$pid: process cwd is unreachable\n" if($self->{debug});
+	return undef;
+    }
+
     # get original ARGV
     (my $bin, local @ARGV) = nr_parse_cmd($pid);
 
@@ -106,6 +113,13 @@ sub files {
     my $cwd = getcwd();
     chdir("/proc/$pid/root/$ptable->{cwd}");
 
+    # skip the process if the cwd is unreachable (i.e. due to mnt ns)
+    unless(getcwd()) {
+	chdir($cwd);
+	print STDERR "$LOGPREF #$pid: process cwd is unreachable\n" if($self->{debug});
+	return ();
+    }
+
     # get original ARGV
     (my $bin, local @ARGV) = nr_parse_cmd($pid);
 

diff --git a/perl/lib/NeedRestart/Interp/Python.pm b/perl/lib/NeedRestart/Interp/Python.pm
@@ -85,11 +85,18 @@ sub source {
     my $ptable = nr_ptable_pid($pid);
     unless($ptable->{cwd}) {
 	print STDERR "$LOGPREF #$pid: could not get current working directory, skipping\n" if($self->{debug});
-	return ();
+	return undef;
     }
     my $cwd = getcwd();
     chdir("/proc/$pid/root/$ptable->{cwd}");
 
+    # skip the process if the cwd is unreachable (i.e. due to mnt ns)
+    unless(getcwd()) {
+	chdir($cwd);
+	print STDERR "$LOGPREF #$pid: process cwd is unreachable\n" if($self->{debug});
+	return undef;
+    }
+
     # get original ARGV
     (my $bin, local @ARGV) = nr_parse_cmd($pid);
 
@@ -137,6 +144,13 @@ sub files {
     my $cwd = getcwd();
     chdir("/proc/$pid/root/$ptable->{cwd}");
 
+    # skip the process if the cwd is unreachable (i.e. due to mnt ns)
+    unless(getcwd()) {
+	chdir($cwd);
+	print STDERR "$LOGPREF #$pid: process cwd is unreachable\n" if($self->{debug});
+	return ();
+    }
+
     # get original ARGV
     (my $bin, local @ARGV) = nr_parse_cmd($pid);
 

diff --git a/perl/lib/NeedRestart/Interp/Ruby.pm b/perl/lib/NeedRestart/Interp/Ruby.pm
@@ -82,11 +82,18 @@ sub source {
     my $ptable = nr_ptable_pid($pid);
     unless($ptable->{cwd}) {
 	print STDERR "$LOGPREF #$pid: could not get current working directory, skipping\n" if($self->{debug});
-	return ();
+	return undef;
     }
     my $cwd = getcwd();
     chdir("/proc/$pid/root/$ptable->{cwd}");
 
+    # skip the process if the cwd is unreachable (i.e. due to mnt ns)
+    unless(getcwd()) {
+	chdir($cwd);
+	print STDERR "$LOGPREF #$pid: process cwd is unreachable\n" if($self->{debug});
+	return undef;
+    }
+
     # get original ARGV
     (my $bin, local @ARGV) = nr_parse_cmd($pid);
 
@@ -134,6 +141,13 @@ sub files {
     my $cwd = getcwd();
     chdir("/proc/$pid/root/$ptable->{cwd}");
 
+    # skip the process if the cwd is unreachable (i.e. due to mnt ns)
+    unless(getcwd()) {
+	chdir($cwd);
+	print STDERR "$LOGPREF #$pid: process cwd is unreachable\n" if($self->{debug});
+	return ();
+    }
+
     # get original ARGV
     (my $bin, local @ARGV) = nr_parse_cmd($pid);