Do not call GetTerminalSize if STDOUT is not a tty #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liske
requested changes
Apr 6, 2018
perl/lib/NeedRestart/UI.pm
Outdated
| @@ -129,8 +129,9 @@ sub _progress_inc { | |||
|
|
|||
| sub _progress_out { | |||
| my $self = shift; | |||
|
|
|||
| my ($columns) = GetTerminalSize(\*STDOUT); | |||
| my $columns = 10; | |||
perl/lib/NeedRestart/UI.pm
Outdated
| @@ -142,10 +143,11 @@ sub _progress_out { | |||
|
|
|||
| sub _progress_fin { | |||
| my $self = shift; | |||
| my $columns; | |||
There was a problem hiding this comment.
The variable should also be set to 80 to prevent perl warnings about using undefined value in line 152.
Followup of the bug fix in liske#86, triggered by running needrestart with yum/dnf in cron
mscherer
force-pushed
the
do_not_fail_without_tty
branch
from
66a4008
to
b443024
Compare
|
Done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of the bug fix in #86, triggered by running needrestart
with yum/dnf in cron