Don't fail when terminal says 0 columns #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, I would like to merge it but:
|
|
Done! |
liske
reviewed
Nov 6, 2019
perl/lib/NeedRestart/UI.pm
Outdated
| sub _get_columns { | ||
| my $default_columns = 80; # Sane default | ||
| if (-t *STDOUT) { | ||
| my ($columns) = GetTerminalSize(\*STDOUT); |
There was a problem hiding this comment.
Please pass the filehandle twice due to Debian Bug#824564 (as already done in wprint).
Some terminals say their width is 0. In that case, use some default width rather than displaying ugly warnings. See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=942759
|
Thomas Liske writes:
+ my ($columns) = GetTerminalSize(\*STDOUT);
Please pass the filehandle twice due to Debian Bug#824564 (as already done in wprint).
Done!
…--
Fabrice BAUZAC-STEHLY
PGP 015AE9B25DCB0511D200A75DE5674DEA514C891D
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some terminals say their width is 0. In that case, use some default
width rather than displaying ugly warnings.
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=942759