Fixes for LXC / LXD container support #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liske
requested changes
Aug 18, 2020
added 4 commits
August 18, 2020 11:57
This is the recommended way to install LXD and puts the container dirs in /var/snap/lxd/common/lxd/containers instead of /var/lib/lxd/containers.
LXC containers on newer versions of LXC are under the lxc.payload cgroup, update the cgroup regex to match this too.
Check if containers are in a project and add the appropriate parameter to the restart command.
liske
approved these changes
Sep 19, 2020
|
Thanks and sorry for the long delay. I somehow missed your update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support LXD installed via snapd, which is the recommended installation method.
Update the regex for matching container cgroups (since LXC 3.1, containers have separate lxc.payload and lxc.monitor cgroups for the container processes and the monitor).
Recognise containers in LXD projects (added in LXD 4.0) and generate the proper command to restart them.