ignore USBGuard #257
Merged
ignore USBGuard #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When any of USBGuard’s `PresentDevicePolicy`- and `PresentControllerPolicy`- options are set to `apply-policy`, `block` or `reject`, then a restart of `usbguard.service` might cause a previously manually allowed device to no longer be so. If that’s e.g. a device holding a mounted filesystem, that mount would immediately be interrupted (not in a clean way) and data corruption might occur. Restarting `usbguard-dbus.service` doesn’t seem to be a problem, though. Ideally this would be fixed in USBGuard and I’ve filed an issue for that: USBGuard/usbguard#565 Once that would have been implemented, this commit should be reverted. Signed-off-by: Christoph Anton Mitterer <mail@christoph.anton.mitterer.name>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When any of USBGuard’s
PresentDevicePolicy- andPresentControllerPolicy- options are set toapply-policy,blockorreject, then a restart ofusbguard.servicemight cause a previously manually allowed device to no longer be so.If that’s e.g. a device holding a mounted filesystem, that mount would immediately be interrupted (not in a clean way) and data corruption might occur.
Restarting
usbguard-dbus.servicedoesn’t seem to be a problem, though.Ideally this would be fixed in USBGuard and I’ve filed an issue for that: USBGuard/usbguard#565
Once that would have been implemented, this commit should be reverted.
Signed-off-by: Christoph Anton Mitterer mail@christoph.anton.mitterer.name