Support dbus replacements #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Vladimir-csp
commented
Aug 3, 2023
•
Vladimir-csp
commented
- Operate with proper unit ID of active dbus service (i.e. dbus-broker.service)
- ID starting point is hook name, support dbus-broker.service via a symlink
- Kill PIDs of dbus service after restart (sometimes dbus processes linger, causing troubles)
- Terminate users, not sessions (this also deallocates resources, including user dbus instances)
- Rewrite command creation logic, pre-render command
- Better messaging
* Operate with proper unit ID of active dbus service (i.e. dbus-broker.service) * ID starting point is hook name, support dbus-broker.service via a symlink * Kill PIDs of dbus service after restart (sometimes dbus processes linger, causing troubles) * Rewrite command creation logic, pre-render command * Better messaging
With systemd-timesyncd inside, fixes liske#255
Replace some external calls with builtins, use ps instead of readlink on /proc/..., prettify.
Even better solution for liske#255, not relying on hardcoded lists
Order of properties in `systemctl show` output is undefined, use blank lines and ending marker as a trigger to test and capture previous values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.