apply override_rc deterministically #280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying conf.d overrides to enable restarts for services that already have matching entries in the default override_rc, we can use a form like:
For proper behavior, we need to provide a regex that is exactly the same as the one in the default override_rc; needrestart matches against regexes in order and stops on the first match. What if there is a typo, though? Note the "servic" typo in the example above; this is a valid regex, but it's not quite the same as the one in the default override_rc.
Currently, if there are two matching regexes, the one that takes effect is random, with a 50% probability for each. This is due to behavior in relatively modern perl. Perl versions >= 5.18 evaluate hashes in an order that randomly differs from run to run.
https://perldoc.perl.org/perl5180delta
To provide deterministic behavior, sort the keys first. That way, the first matching regex will always win, and the intended override will either always work or never work.