Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix AMD ucode checking in non-debug mode #288

Merged
merged 2 commits into from
Feb 25, 2024
Merged

fix AMD ucode checking in non-debug mode #288

merged 2 commits into from
Feb 25, 2024

Conversation

anarcat
Copy link
Contributor

@anarcat anarcat commented Nov 15, 2023

It looks like the assignment when the ucode exist was not done unless debug (-v) was set. Therefore, all AMD microcode checks were returning UNKNOWN, including in Nagios checks, unless the -v ("verbose", but actually debug) was passed.

Closes: #249

@anarcat
fix AMD ucode checking in non-debug mode
b073fb6 
It looks like the assignment when the ucode exist was not
done *unless* `debug` (`-v`) was set. Therefore, all AMD microcode
checks were returning UNKNOWN, including in Nagios checks, unless the
`-v` ("verbose", but actually `debug`) was passed.

Closes: liske#249
This was referenced Nov 15, 2023
Closed
Closed
@anarcat
Copy link
Contributor Author

anarcat commented Nov 15, 2023

i tested this on our fleet. it works on two of the 4 affected AMD hosts. those two hosts do have the right firmware version loaded from the /lib/firmware blobs.

the two hosts that still report UNKNOWN simply do not do not have a firmware file available in there. that is what #285 aims to fix, but I'm not sure we should fix this in the first place... after all the Intel code has the same behavior, as @mmitch mentioned in #226... so i'm not fixing that here and will resolve that problem out of band, by removing the check for those hosts.

alternatively, if we do want to fix that issue, we should do it for Intel as well...

@anarcat
Copy link
Contributor Author

anarcat commented Nov 15, 2023 •
edited
Loading

alternatively, if we do want to fix that issue, we should do it for Intel as well...

edit: fup in #285 (comment) instead.

This was referenced Nov 15, 2023
Merged
Merged
Closed
@liske liske merged commit a0e94ea into liske:master Feb 25, 2024
@liske
Copy link
Owner

liske commented Feb 25, 2024 •
edited
Loading

Thanks! Their was also #278 pending fixing the same issue.

@anarcat anarcat deleted the amd-non-verbose branch February 26, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing to check for AMD processor microcode upgrades
2 participants
@anarcat @liske