Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark unavailable firmware as CURRENT #290

Merged
merged 1 commit into from
Aug 9, 2024
Merged

mark unavailable firmware as CURRENT #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions perl/lib/NeedRestart/uCode.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,26 @@ my $LOGPREF = '[ucode]';
sub compare_ucode_versions {
my ($debug, $processor, %vars) = @_;

unless ( exists( $vars{CURRENT} ) && exists( $vars{AVAIL} ) ) {
print STDERR
"$LOGPREF #$processor did not get current microcode version\n"
if ( $debug && !exists( $vars{CURRENT} ) );
# if no firmware is available for the current CPU, that's
# considered up to date. the rationale here is that if we warn on
# this, we're actually going to warn for certain new CPUs that
# have an up-to-date, built-in firmware without any update. that,
# in turn, creates alert fatigue and makes operators more likely
# to ignore warnings.
unless ( exists( $vars{AVAIL} ) ) {
print STDERR
"$LOGPREF #$processor did not get available microcode version\n"
if ( $debug && !exists( $vars{AVAIL} ) );
if ( $debug );
return NRM_CURRENT;
}
# from here on, there is a microcode file available
#
# if we can't find a microcode firmware for the current CPU,
# *that* is a problem.
unless ( exists( $vars{CURRENT} ) ) {
print STDERR
"$LOGPREF #$processor did not get current microcode version\n"
if ( $debug);

return NRM_UNKNOWN;
}
Expand Down