shellcheck fixes

ex/apt/dpkg-status

@@ -22,7 +22,7 @@ mkdir -p "$RUNDIR"
 touched=0
 errored=0
 
-while read tag p0 p1 p2 p3 p4 pp; do
+while read -r tag p0 p1 p2 p3 p4 pp; do
     if [ "$tag" = 'status:' ] && [ "$p1" = 'unpacked' ]; then
         if [ "$touched" = 0 ]; then
             touch "$RUNDIR/unpacked"

ex/notify.d/400-notify-send

@@ -34,8 +34,10 @@ case "$NR_SESSION" in
         unset DBUS_SESSION_BUS_ADDRESS
     fi
 
-    export DISPLAY=$(sed -z -n s/^DISPLAY=//p "/proc/$NR_SESSPPID/environ")
-    export XAUTHORITY=$(sed -z -n s/^XAUTHORITY=//p "/proc/$NR_SESSPPID/environ")
+    DISPLAY=$(sed -z -n s/^DISPLAY=//p "/proc/$NR_SESSPPID/environ")
+    export DISPLAY
+    XAUTHORITY=$(sed -z -n s/^XAUTHORITY=//p "/proc/$NR_SESSPPID/environ")
+    export XAUTHORITY
 
     if [ -z "$DISPLAY" ]; then
         echo "[$0] could not find DISPLAY for $NR_USERNAME on $NR_SESSION" 1>&2

ex/restart.d/dbus.service

@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 
 # by Vladimir Kudrya
 # https://github.com/Vladimir-csp/
@@ -35,9 +35,9 @@ get_active_deps(){
 	{
 		systemctl list-dependencies -l --reverse --plain dbus.socket
 		systemctl list-dependencies -l --reverse --plain dbus.service
-	} | grep -o '[^[:space:]]\+.service' | sort -u | while read SERVICE
+	} | grep -o '[^[:space:]]\+.service' | sort -u | while read -r SERVICE
 	do
-		if [ "$SERVICE" != "dbus.service" -a "$SERVICE" != "$DISPLAY_MANAGER" ] && systemctl -q is-active "$SERVICE"
+		if [ "$SERVICE" != "dbus.service" ] && [ "$SERVICE" != "$DISPLAY_MANAGER" ] && systemctl -q is-active "$SERVICE"
 		then
 			echo "$SERVICE"
 		fi
@@ -62,7 +62,7 @@ $ACTIVE_DEPS
 $DISPLAY_MANAGER
 EOF
 
-[ -t 0 ] && read -p "Press Enter to continue > " PRESSENTER
+[ -t 0 ] && read -pr "Press Enter to continue > " PRESSENTER
 
 # prepare list to be a CLI arg
 ACTIVE_DEPS="$(echo "$ACTIVE_DEPS" | tr '\n' ' ')"

lib/iucode-scan-versions

@@ -63,7 +63,7 @@ test -r /etc/default/intel-microcode && . /etc/default/intel-microcode
 test "$IUCODE_TOOL_INITRAMFS" = "no" && exit 0
 
 # run iucode_tool to scan for microcodes
-if [ -r /usr/share/misc/intel-microcode* ]; then
+if [ -n "$(find /usr/share/misc -maxdepth 1 -type f -name 'intel-microcode*' -perm /u+r)" ]; then
     exec iucode_tool -l $filter --ignore-broken -tb /lib/firmware/intel-ucode -ta /usr/share/misc/intel-microcode* 2>&1
     exit $?
 fi

lib/notify.d.sh

@@ -31,4 +31,5 @@ fi
 . "$GETTEXTLIB"
 
 # Get LANG of session
-export LANG=$(sed -z -n s/^LANG=//p "/proc/$NR_SESSPPID/environ")
+LANG=$(sed -z -n s/^LANG=//p "/proc/$NR_SESSPPID/environ")
+export LANG

lib/vmlinuz-get-version

@@ -31,8 +31,8 @@ try_decompress()
     # Try to find the header ($1) and decompress from here
     for pos in $(tr "$1\n$2" "\n$2=" < "$img" | grep -abo "^$2"); do
         pos=${pos%%:*}
-        tail -c+$pos "$img" | $3 > $tmp 2>/dev/null
-        get_version $tmp
+        tail -c+"$pos" "$img" | $3 > "$tmp" 2>/dev/null
+        get_version "$tmp"
     done
 }
 
@@ -50,10 +50,10 @@ fi
 
 # Prepare temp files:
 tmp=$(mktemp)
-trap "rm -f $tmp" 0
+trap 'rm -f "$tmp"' 0
 
 # Initial attempt for uncompressed images or objects:
-get_version $img
+get_version "$img"
 
 # That didn't work, so retry after decompression.
 which gunzip  > /dev/null && try_decompress '\037\213\010' xy    gunzip