review feedback for rebase over kiln (ethereum#97)

core/blockchain.go

@@ -1594,12 +1594,7 @@ func (bc *BlockChain) insertChain(chain types.Blocks, verifySeals, setHead bool)
 
  // Process block using the parent state as reference point
  substart := time.Now()
- var (
- usedGas uint64
- receipts types.Receipts
- logs []*types.Log
- )
- receipts, logs, usedGas, err = bc.processor.Process(block, statedb, bc.vmConfig)
+ receipts, logs, usedGas, err := bc.processor.Process(block, statedb, bc.vmConfig)
  if err != nil {
  bc.reportBlock(block, receipts, err)
  atomic.StoreUint32(&followupInterrupt, 1)

core/state/state_object.go

@@ -612,25 +612,10 @@ func (s *stateObject) Balance() *big.Int {
  return s.data.Balance
 }
 
-func (s *stateObject) BalanceLE() []byte {
- var out [32]byte
- for i, b := range s.data.Balance.Bytes() {
- out[len(s.data.Balance.Bytes())-1-i] = b
- }
-
- return out[:]
-}
-
 func (s *stateObject) Nonce() uint64 {
  return s.data.Nonce
 }
 
-func (s *stateObject) NonceLE() []byte {
- var out [32]byte
- binary.LittleEndian.PutUint64(out[:8], s.data.Nonce)
- return out[:]
-}
-
 // Never called, but must be present to allow stateObject to be used
 // as a vm.Account interface that also satisfies the vm.ContractRef
 // interface. Interfaces are awesome.

core/types/access_witness.go

@@ -39,7 +39,6 @@ const (
 
 // AccessWitness lists the locations of the state that are being accessed
 // during the production of a block.
-// TODO(@gballet) this doesn't fully support deletions
 type AccessWitness struct {
  // Branches flags if a given branch has been loaded
  Branches map[VerkleStem]Mode

core/vm/interpreter.go

@@ -197,7 +197,6 @@ func (in *EVMInterpreter) Run(contract *Contract, input []byte, readOnly bool) (
  contract.Gas -= touchEachChunksOnReadAndChargeGas(pc, 1, contract.Address().Bytes()[:], contract.Code, contract, in.evm.TxContext.Accesses, contract.IsDeployment)
  }
 
- // TODO how can we tell if we are in stateless mode here and need to get the op from the witness
  // If we are in witness mode, then raise an error
  op = contract.GetOp(pc)