Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using eval inside def-test #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

digikar99
Copy link

@digikar99 digikar99 commented Apr 16, 2021

Is there a reason about why things are the way they are?

For my purposes, the use of eval (or even compile) causes a significant overhead (several times as much as the system-to-be-tested itself) in repeated loads of the same system.

Edit: This does break code-containing-macros-with-helper-functions if the tests are in the same file, but I do think this is worth it in the longer run unless there are some other issues.

Edit 2: I'm not entirely sure about merging this; one could try, but in quicklisp alone, there are 300+ systems that depend on fiveam; one could always revert if too many things break.

Edit 3: This also fixes "Fiveam cannot find variables declared in a closure surrounding the test. For example, the following fails." mentioned at https://sabracrolleton.github.io/testing-framework#orga8e7410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant