Add response specs #6

bombaywalla · 2024-08-20T00:11:19Z

Added support for generating response specs in addition to parameter specs.
With rudimentary tests.

If there is no content, just return a nil? schema without any other processing. If the media type is "default" they convert to a keyword, otherwsie leave it as a string. This is how Reitit wants it.

lispyclouds · 2024-08-20T06:46:42Z

Hey hey @bombaywalla long time! Thanks a lot for this, will take a proper look and get back asap.

src/navi/core.clj

test/navi/core_test.clj

bombaywalla · 2024-08-20T21:02:16Z

Thanks for the feedback.
I've pushed a new commit with the changes discussed.

lispyclouds · 2024-08-21T09:37:36Z

You could also take out the response coercions from the unsupported section on the readme too in this PR :)

Since a LinkedHashMap implements HashMap, a LinkedHashMap "just works" with Clojure, without any interop needed. So, re-wrote it using reduce-kv. Changed the position of the map parameter from last to first in order to be consistent with update-keys and update-vals. Refactored other code to use update-kvs. Some minor comment changes.

bombaywalla · 2024-08-22T01:12:14Z

Inspired by your experimentations with LinkedHashMap, I found that since a LinkedHashMap also implements HashMap, Clojure "just works" with it without any interop needed. So I re-wrote linked-hash-ma->clj-map to just use reduce-kv and since it is no longer interop-dependent, I renamed it to update-kvs and changed the parameter ordering to keep the map first, like update-keys and update-vals.

I also refactored the other code to use update-kvs. And I moved the definition of update-kvs to earlier in the file.

I updated the README to reflect current reality.

See what you think of the current state and let me know if it can be made better.

Thanks!

src/navi/core.clj

test/navi/core_test.clj

lispyclouds · 2024-08-22T08:01:49Z

Thanks a lot for the efforts and it looks good! Lemme know what you think of my extra change and post that we should be good to merge.

bombaywalla added 7 commits August 19, 2024 11:50

First cut at handling responses as well.

b6df097

Removed unneeded require of clojure.string.

2b67486

Remove unintentional typo.

ac12897

Fix the handling of the response.

8539c47

If there is no content, just return a nil? schema without any other processing. If the media type is "default" they convert to a keyword, otherwsie leave it as a string. This is how Reitit wants it.

Set warn-on-reflection.

7a425fc

First cut at tests for responses.

b9b6c9f

Moved comment to more appropriate location.

1226605