Update playground-elements to v0.18.0 #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A live preview of this PR will be available at the URL(s) below. |
augustjk
approved these changes
May 25, 2023
Member
augustjk
left a comment
augustjk
left a comment
There was a problem hiding this comment.
Awesome! I can confirm the issue is gone for me in the preview.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1128
Testing
Apart from our unit test coverage, I also manually checked the tutorials & code samples on the site.
Because the bundled version has been updated to TS 5, there is a chance that certain gists and prior code now has TS errors. However that does not seem to be avoidable unless we add a feature to bundle TypeScript versions.