[lit-html] add Lit 2 directive syntax to Lit 1 #1654

e111077 · 2021-03-05T04:11:09Z

Add forwards compatibility for Lit 1 directives. This will allow users to write with the Lit 2 directive class syntax and also adds some files so that the we can migrate users to the new import targets and then switch them to Lit 2 rather than those changes being atomic.

Notable changes:

directive can now take a DirectiveClass as an argument in lit-html/directives
The API of the lit 2 [a-zA-Z]+Parts have added to lit-html/directives
creation of root level:
- async-directive.ts
- directive.ts
creation of ChildPart

Note: this seems to have broken lit-analyzer 1.1.9 internally, but i could not reproduce those errors externally. This seems to work just fine in lit-analyzer 1.2.0.

Additionally, usage of ChildPart in a directive may cause lit-analyzer to not detect that a directive is a directive, but this should not cause any failures because NodePart (Lit 1 equivalent) is never bound to anything that needs type checking.

Related #1653

kevinpschaaf

Just a few minor questions

src/directive.ts

src/async-directive.ts

src/directive.ts

kevinpschaaf · 2021-03-17T18:02:47Z

We also need to add forward-compat for at least directive-helpers.js:isTemplateResult (needed for open-wc/storybook to migrate to hybrid support 1.x and 2.x).

We should also consider adding these to the directive-helpers.js:

isTemplateResult
insertPart
setChildPartValue
setCommittedValue
getCommittedValue
removePart
clearPart

Seems like they would be required to migrate more advanced directives.

src/directive-helpers.ts

kevinpschaaf

LGTM, pending CI green(formatting issues?).

Added some suggestions for the API docs for the callbacks (I realize the lit-next ones only had one API doc for both callbacks; we'll have to fix it there also.

src/async-directive.ts

src/directive.ts

Co-authored-by: Kevin Schaaf <kschaaf@google.com>

src/directive-helpers.ts

Co-authored-by: Russell Bicknell <bicknellr@google.com>

justinfagnani

Once the cache issue is fixed and there are some tests this looks good.

src/directive.ts

src/async-directive.ts

src/directive.ts

src/test/directives/migration-directives_test.ts

sorvell

LGTM

e111077 · 2021-04-02T00:20:54Z

Ping @justinfagnani to update review

src/test/directives/migration-directives_test.ts

src/directive.ts

e111077 · 2021-04-02T04:48:35Z

ugh i had to format and I need an LGTM again

* Remove trusted types mention from changelog * Adds rendering test composing parts and slots (#1077) * Adds rendering test composing parts and slots Tests if #1046 has been addressed in the webcomponents polyfills. * Update @webcomponents/webcomponentsjs dev dependency to required version * Add 1.2.0 release notes (#1104) * Don't disturb imperatively added classes in classMap (#1112) Fix #1111 Revert classMap to previous implementation, but don't use classList or className. * Fix lint errors (#1116) * Prepare 1.2.0-pre.1 release (#1117) * Link changelog issue (#1118) * Prepare 1.2.0 release (#1128) * Use downlevel-dts, test compile in TS 3.4 (#1129) * Use downlevel-dts, test compile in TS 3.4 Related to lit/lit-element#935 Haven't heard anything about this being a problem for lit-html, but better to be ahead of any issues. * Lock typescript version at ~3.8 Prevent breakage for devs coming into the lit-html repo and doing `npm install` after a new breaking release of TypeScript * Prepare 1.2.1 release (#1130) * Update new task template * Update lint dependencies (#1099) * Update a broken link in the documentation. (#1138) * Doc usability improvements. Fixes #1133. (#1147) * Doc usability improvements. Fixes #1133. * Address feedback. * Fix typo. (#1152) * Update issue templates added label * Restore trusted types (#1153) * Revert "Revert "Add trusted types support to lit html (#970)"" This reverts commit cedf4b3. It also refactors the trusted types tests so that they can run with native trusted types enabled. Also revamp the trusted types tests, and run all lit-html tests with trusted types enabled on browsers that support it natively. * Adds the correct path information to the release notes links for #1163 (#1164) * Updating links in guide to point to correct guides https://lit-html.polymer-project.org/guide/release-notes * Didn't need to actually go down a level in the dir * Update docs/guide/release-notes/1.2.0.md Co-authored-by: Arthur Evans <arthure@google.com> * Update docs/guide/release-notes/1.2.0.md Co-authored-by: Arthur Evans <arthure@google.com> * Update docs/guide/release-notes/1.2.0.md Co-authored-by: Arthur Evans <arthure@google.com> Co-authored-by: Arthur Evans <arthure@google.com> * Correct copyright dates. (#1171) * Add BLM banner (#1172) * docs: fixed small error (#1180) Since this is just a typo fix in the README, I'm going to go ahead and merge it. * Fix api doc (#1178) * Fixes #1177. * Fix links. * Remove unneeded typedoc tags. * Redirect old API URLs. * Update firefox and edge logo (#1161) Co-authored-by: Arthur Evans <arthure@google.com> * Update dev server recommendations (#1059) * Update dev server recommendations Came here to fix a broken link, got more than I bargained for. Other recommendations (like linting and IDE plugins) may need updating as well. * Address comments. * Fix typos, add notes on attribute prefixes. (#933) * Fix typos, add notes on attribute prefixes. * More detail on strings param * Run format. * Make IDE plugins links, change recommendation (#956) * Make IDE plugins links, change recommendation I think we should recommend runem.lit-plugin because it supports type checking of template bindings, and it seems to be robust (I ran it across all of google3 and there were only a small number of issues, which I'm sending out PRs for) * Address feedback, update linting suggestion. * Address more feedback. Co-authored-by: Arthur Evans <arthure@google.com> * Bump lodash from 4.17.15 to 4.17.19 in /docs (#1183) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arthur Evans <arthure@google.com> * Set type in package.json to "module" (#1146) This would let Node >=13 to load lit-html as ES modules without any other bundling tools. Move check-version-tracker file extension to .cjs to continue loading it as cjs. * Fix trusted types tests. (#1193) * Fix trusted types tests. Also fix support for trusted types in the unsafeSVG directive. Have to handle IE separately in unsafe-svg because apparently the svgElement.innerHTML setter is a no op in IE :/ * chore(shady-render): export shadyTemplateFactory (#1135) * Update changelog for 1.3.0 * Prepare 1.3.0-pre.1 release * Add 1.3.0 release notes (#1202) * Prep 1.3.0 release * Update package lock * Remove ts3.4 typings before generating * Update Tachometer * Add chromedriver as a devDependency * Fix flaky async-append test * Update build docs (#1201) * Revised build docs WIP. * Update build docs. Fixes #1148. * Address feedback. * Address feedback, fix typos. * Create lit-html-next-bug-report.md (#1308) * Create lit-html-next-bug-report.md Add issue template * Apply suggestions from code review * Create lit-element@next-major issue template (#1320) * Create lit-element-next-bug-report.md * Apply suggestions from code review * Fix issue template formatting * Fix styleMap example (#1433) Example function has a body, hence it doesn't have an implicit return value. An explicit return value is needed for the example to make sense. * Fix typos in 03-styling-templates.md (#1511) * Fix typos in 06-template-reference.md (#1562) * [lit-html] add Lit 2 directive syntax to Lit 1 (#1654) Co-authored-by: Kevin Schaaf <kschaaf@google.com> Co-authored-by: Russell Bicknell <bicknellr@google.com> * Small fixes to 1.3.0 release ntoes (#1719) * Correct evasive typo (#1725) change "current" -> "currently" * Small tweaks to forward-compat directives (#1748) * [lit-html] Update Twitter handle from polymer -> buildWithLit (#1779) * Add version banner, landing page redirect. (#1786) * [lit-html] Prepare v1.4.0 release (#1809) Co-authored-by: Justin Fagnani <justinfagnani@google.com> Co-authored-by: Steve Orvell <sorvell@google.com> Co-authored-by: Abraham Williams <4braham@gmail.com> Co-authored-by: Peter Burns <rictic@google.com> Co-authored-by: Abdón Rodríguez Davila <a@abdonrd.com> Co-authored-by: Lukas Papay <papay.lukas@gmail.com> Co-authored-by: Arthur Evans <arthure@google.com> Co-authored-by: nicolejadeyee <nicolejadeyee@gmail.com> Co-authored-by: Paul Kinlan <paul.kinlan@gmail.com> Co-authored-by: 0xflotus <0xflotus@gmail.com> Co-authored-by: Felix Schulze Sindern <47390169+FelixSchuSi@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: vikerman <vikerman@users.noreply.github.com> Co-authored-by: Manuel Martín <manuel.martin@gmail.com> Co-authored-by: tikotus <jahvenni@gmail.com> Co-authored-by: Nicolás Font <nicolasfont@gmail.com> Co-authored-by: Vadim Filimonov <philimonovvadim@gmail.com> Co-authored-by: Elliott Marquez <emarquez@google.com> Co-authored-by: Kevin Schaaf <kschaaf@google.com> Co-authored-by: Todd Pressley <todd.pressley1@gmail.com> Co-authored-by: Elliott Marquez <me@elliottmarquez.dev>

* Remove trusted types mention from changelog * Adds rendering test composing parts and slots (#1077) * Adds rendering test composing parts and slots Tests if #1046 has been addressed in the webcomponents polyfills. * Update @webcomponents/webcomponentsjs dev dependency to required version * Add 1.2.0 release notes (#1104) * Don't disturb imperatively added classes in classMap (#1112) Fix #1111 Revert classMap to previous implementation, but don't use classList or className. * Fix lint errors (#1116) * Prepare 1.2.0-pre.1 release (#1117) * Link changelog issue (#1118) * Prepare 1.2.0 release (#1128) * Use downlevel-dts, test compile in TS 3.4 (#1129) * Use downlevel-dts, test compile in TS 3.4 Related to lit/lit-element#935 Haven't heard anything about this being a problem for lit-html, but better to be ahead of any issues. * Lock typescript version at ~3.8 Prevent breakage for devs coming into the lit-html repo and doing `npm install` after a new breaking release of TypeScript * Prepare 1.2.1 release (#1130) * Update new task template * Update lint dependencies (#1099) * Update a broken link in the documentation. (#1138) * Doc usability improvements. Fixes #1133. (#1147) * Doc usability improvements. Fixes #1133. * Address feedback. * Fix typo. (#1152) * Update issue templates added label * Restore trusted types (#1153) * Revert "Revert "Add trusted types support to lit html (#970)"" This reverts commit cedf4b3. It also refactors the trusted types tests so that they can run with native trusted types enabled. Also revamp the trusted types tests, and run all lit-html tests with trusted types enabled on browsers that support it natively. * Adds the correct path information to the release notes links for #1163 (#1164) * Updating links in guide to point to correct guides https://lit-html.polymer-project.org/guide/release-notes * Didn't need to actually go down a level in the dir * Update docs/guide/release-notes/1.2.0.md Co-authored-by: Arthur Evans <arthure@google.com> * Update docs/guide/release-notes/1.2.0.md Co-authored-by: Arthur Evans <arthure@google.com> * Update docs/guide/release-notes/1.2.0.md Co-authored-by: Arthur Evans <arthure@google.com> Co-authored-by: Arthur Evans <arthure@google.com> * Correct copyright dates. (#1171) * Add BLM banner (#1172) * docs: fixed small error (#1180) Since this is just a typo fix in the README, I'm going to go ahead and merge it. * Fix api doc (#1178) * Fixes #1177. * Fix links. * Remove unneeded typedoc tags. * Redirect old API URLs. * Update firefox and edge logo (#1161) Co-authored-by: Arthur Evans <arthure@google.com> * Update dev server recommendations (#1059) * Update dev server recommendations Came here to fix a broken link, got more than I bargained for. Other recommendations (like linting and IDE plugins) may need updating as well. * Address comments. * Fix typos, add notes on attribute prefixes. (#933) * Fix typos, add notes on attribute prefixes. * More detail on strings param * Run format. * Make IDE plugins links, change recommendation (#956) * Make IDE plugins links, change recommendation I think we should recommend runem.lit-plugin because it supports type checking of template bindings, and it seems to be robust (I ran it across all of google3 and there were only a small number of issues, which I'm sending out PRs for) * Address feedback, update linting suggestion. * Address more feedback. Co-authored-by: Arthur Evans <arthure@google.com> * Bump lodash from 4.17.15 to 4.17.19 in /docs (#1183) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arthur Evans <arthure@google.com> * Set type in package.json to "module" (#1146) This would let Node >=13 to load lit-html as ES modules without any other bundling tools. Move check-version-tracker file extension to .cjs to continue loading it as cjs. * Fix trusted types tests. (#1193) * Fix trusted types tests. Also fix support for trusted types in the unsafeSVG directive. Have to handle IE separately in unsafe-svg because apparently the svgElement.innerHTML setter is a no op in IE :/ * chore(shady-render): export shadyTemplateFactory (#1135) * Update changelog for 1.3.0 * Prepare 1.3.0-pre.1 release * Add 1.3.0 release notes (#1202) * Prep 1.3.0 release * Update package lock * Remove ts3.4 typings before generating * Update Tachometer * Add chromedriver as a devDependency * Fix flaky async-append test * Update build docs (#1201) * Revised build docs WIP. * Update build docs. Fixes #1148. * Address feedback. * Address feedback, fix typos. * Create lit-html-next-bug-report.md (#1308) * Create lit-html-next-bug-report.md Add issue template * Apply suggestions from code review * Create lit-element@next-major issue template (#1320) * Create lit-element-next-bug-report.md * Apply suggestions from code review * Fix issue template formatting * Fix styleMap example (#1433) Example function has a body, hence it doesn't have an implicit return value. An explicit return value is needed for the example to make sense. * Fix typos in 03-styling-templates.md (#1511) * Fix typos in 06-template-reference.md (#1562) * [lit-html] add Lit 2 directive syntax to Lit 1 (#1654) Co-authored-by: Kevin Schaaf <kschaaf@google.com> Co-authored-by: Russell Bicknell <bicknellr@google.com> * Small fixes to 1.3.0 release ntoes (#1719) * Correct evasive typo (#1725) change "current" -> "currently" * Small tweaks to forward-compat directives (#1748) * [lit-html] Update Twitter handle from polymer -> buildWithLit (#1779) * Add version banner, landing page redirect. (#1786) * [lit-html] Prepare v1.4.0 release (#1809) * build: add lit 2 directive files for publish (#1841) * Prepare lit-html 1.4.1 release (#1849) * Update social media links. (#1813) * [lit-html] Add `PropertyPart` to directives forward-compat file. (#1869) * Add `PropertyPart` to directives forward-compat file. * Test that `PartInfo`s provided to directives have the correct `.type`. * Use better names in templates used to test PartInfo. * Remove unnecessary constructor. * format * `lit-html-1.x`: Run tests on GitHub actions (#1967) * Copy test workflow from main branch. * Update test workflows to work with the lit-html-1.x branch. * Run local tests in XVFB * Update `actions/setup-node` and node version. * Remove 'benchmarks.yml' reference in comments. * Delete `.travis.yml` and `travis-bench.sh`. * Initial attempt at porting the benchmarks to a GitHub action. * Update tachometer. * Copy benchmarks workflow from main branch. * Update benchmark workflow to work with the lit-html-1.x branch. * Fix node_modules key. * Update to `actions/setup-node@v2`. * Use `git+https` protocol to avoid SSH which doesn't seem to work. * Move tachometer config to an external file. * Fix benchmark names in report action. * Update chromedriver. * Update URLs and references in tachometer.json . * Update ref in tachometer.json . * Update badge in README.md . * Remove `report-id` field from Tachometer reporter step. * Upstream cl/376929825: Fix compilation issues with TypeScript 4.3. (#1940) Co-authored-by: Justin Fagnani <justinfagnani@google.com> Co-authored-by: Steve Orvell <sorvell@google.com> Co-authored-by: Abraham Williams <4braham@gmail.com> Co-authored-by: Peter Burns <rictic@google.com> Co-authored-by: Abdón Rodríguez Davila <a@abdonrd.com> Co-authored-by: Lukas Papay <papay.lukas@gmail.com> Co-authored-by: Arthur Evans <arthure@google.com> Co-authored-by: nicolejadeyee <nicolejadeyee@gmail.com> Co-authored-by: Paul Kinlan <paul.kinlan@gmail.com> Co-authored-by: 0xflotus <0xflotus@gmail.com> Co-authored-by: Felix Schulze Sindern <47390169+FelixSchuSi@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: vikerman <vikerman@users.noreply.github.com> Co-authored-by: Manuel Martín <manuel.martin@gmail.com> Co-authored-by: tikotus <jahvenni@gmail.com> Co-authored-by: Nicolás Font <nicolasfont@gmail.com> Co-authored-by: Vadim Filimonov <philimonovvadim@gmail.com> Co-authored-by: Elliott Marquez <emarquez@google.com> Co-authored-by: Kevin Schaaf <kschaaf@google.com> Co-authored-by: Todd Pressley <todd.pressley1@gmail.com> Co-authored-by: Elliott Marquez <me@elliottmarquez.dev>

* Remove trusted types mention from changelog * Adds rendering test composing parts and slots (#1077) * Adds rendering test composing parts and slots Tests if #1046 has been addressed in the webcomponents polyfills. * Update @webcomponents/webcomponentsjs dev dependency to required version * Add 1.2.0 release notes (#1104) * Don't disturb imperatively added classes in classMap (#1112) Fix #1111 Revert classMap to previous implementation, but don't use classList or className. * Fix lint errors (#1116) * Prepare 1.2.0-pre.1 release (#1117) * Link changelog issue (#1118) * Prepare 1.2.0 release (#1128) * Use downlevel-dts, test compile in TS 3.4 (#1129) * Use downlevel-dts, test compile in TS 3.4 Related to lit/lit-element#935 Haven't heard anything about this being a problem for lit-html, but better to be ahead of any issues. * Lock typescript version at ~3.8 Prevent breakage for devs coming into the lit-html repo and doing `npm install` after a new breaking release of TypeScript * Prepare 1.2.1 release (#1130) * Update new task template * Update lint dependencies (#1099) * Update a broken link in the documentation. (#1138) * Doc usability improvements. Fixes #1133. (#1147) * Doc usability improvements. Fixes #1133. * Address feedback. * Fix typo. (#1152) * Update issue templates added label * Restore trusted types (#1153) * Revert "Revert "Add trusted types support to lit html (#970)"" This reverts commit cedf4b3. It also refactors the trusted types tests so that they can run with native trusted types enabled. Also revamp the trusted types tests, and run all lit-html tests with trusted types enabled on browsers that support it natively. * Adds the correct path information to the release notes links for #1163 (#1164) * Updating links in guide to point to correct guides https://lit-html.polymer-project.org/guide/release-notes * Didn't need to actually go down a level in the dir * Update docs/guide/release-notes/1.2.0.md Co-authored-by: Arthur Evans <arthure@google.com> * Update docs/guide/release-notes/1.2.0.md Co-authored-by: Arthur Evans <arthure@google.com> * Update docs/guide/release-notes/1.2.0.md Co-authored-by: Arthur Evans <arthure@google.com> Co-authored-by: Arthur Evans <arthure@google.com> * Correct copyright dates. (#1171) * Add BLM banner (#1172) * docs: fixed small error (#1180) Since this is just a typo fix in the README, I'm going to go ahead and merge it. * Fix api doc (#1178) * Fixes #1177. * Fix links. * Remove unneeded typedoc tags. * Redirect old API URLs. * Update firefox and edge logo (#1161) Co-authored-by: Arthur Evans <arthure@google.com> * Update dev server recommendations (#1059) * Update dev server recommendations Came here to fix a broken link, got more than I bargained for. Other recommendations (like linting and IDE plugins) may need updating as well. * Address comments. * Fix typos, add notes on attribute prefixes. (#933) * Fix typos, add notes on attribute prefixes. * More detail on strings param * Run format. * Make IDE plugins links, change recommendation (#956) * Make IDE plugins links, change recommendation I think we should recommend runem.lit-plugin because it supports type checking of template bindings, and it seems to be robust (I ran it across all of google3 and there were only a small number of issues, which I'm sending out PRs for) * Address feedback, update linting suggestion. * Address more feedback. Co-authored-by: Arthur Evans <arthure@google.com> * Bump lodash from 4.17.15 to 4.17.19 in /docs (#1183) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Arthur Evans <arthure@google.com> * Set type in package.json to "module" (#1146) This would let Node >=13 to load lit-html as ES modules without any other bundling tools. Move check-version-tracker file extension to .cjs to continue loading it as cjs. * Fix trusted types tests. (#1193) * Fix trusted types tests. Also fix support for trusted types in the unsafeSVG directive. Have to handle IE separately in unsafe-svg because apparently the svgElement.innerHTML setter is a no op in IE :/ * chore(shady-render): export shadyTemplateFactory (#1135) * Update changelog for 1.3.0 * Prepare 1.3.0-pre.1 release * Add 1.3.0 release notes (#1202) * Prep 1.3.0 release * Update package lock * Remove ts3.4 typings before generating * Update Tachometer * Add chromedriver as a devDependency * Fix flaky async-append test * Update build docs (#1201) * Revised build docs WIP. * Update build docs. Fixes #1148. * Address feedback. * Address feedback, fix typos. * Create lit-html-next-bug-report.md (#1308) * Create lit-html-next-bug-report.md Add issue template * Apply suggestions from code review * Create lit-element@next-major issue template (#1320) * Create lit-element-next-bug-report.md * Apply suggestions from code review * Fix issue template formatting * Fix styleMap example (#1433) Example function has a body, hence it doesn't have an implicit return value. An explicit return value is needed for the example to make sense. * Fix typos in 03-styling-templates.md (#1511) * Fix typos in 06-template-reference.md (#1562) * [lit-html] add Lit 2 directive syntax to Lit 1 (#1654) Co-authored-by: Kevin Schaaf <kschaaf@google.com> Co-authored-by: Russell Bicknell <bicknellr@google.com> * Small fixes to 1.3.0 release ntoes (#1719) * Correct evasive typo (#1725) change "current" -> "currently" * Small tweaks to forward-compat directives (#1748) * [lit-html] Update Twitter handle from polymer -> buildWithLit (#1779) * Add version banner, landing page redirect. (#1786) * [lit-html] Prepare v1.4.0 release (#1809) * build: add lit 2 directive files for publish (#1841) * Prepare lit-html 1.4.1 release (#1849) * Update social media links. (#1813) * [lit-html] Add `PropertyPart` to directives forward-compat file. (#1869) * Add `PropertyPart` to directives forward-compat file. * Test that `PartInfo`s provided to directives have the correct `.type`. * Use better names in templates used to test PartInfo. * Remove unnecessary constructor. * format * `lit-html-1.x`: Run tests on GitHub actions (#1967) * Copy test workflow from main branch. * Update test workflows to work with the lit-html-1.x branch. * Run local tests in XVFB * Update `actions/setup-node` and node version. * Remove 'benchmarks.yml' reference in comments. * Delete `.travis.yml` and `travis-bench.sh`. * Initial attempt at porting the benchmarks to a GitHub action. * Update tachometer. * Copy benchmarks workflow from main branch. * Update benchmark workflow to work with the lit-html-1.x branch. * Fix node_modules key. * Update to `actions/setup-node@v2`. * Use `git+https` protocol to avoid SSH which doesn't seem to work. * Move tachometer config to an external file. * Fix benchmark names in report action. * Update chromedriver. * Update URLs and references in tachometer.json . * Update ref in tachometer.json . * Update badge in README.md . * Remove `report-id` field from Tachometer reporter step. * Upstream cl/376929825: Fix compilation issues with TypeScript 4.3. (#1940) * `lit-html-1.x`: Replace local type declarations for polyfill APIs with those imported from the polyfills. (#2017) * Temporarily add local tarball based off of the `ts-externs` branch in webcomponents/polyfills. * Use the polyfill tarball package. * Remove local polyfill type declarations and reference those from the polyfill package instead. * format * Update webcomponentsjs tarball. * Replace local polyfills tarball with `@webcomponents/webcomponentsjs@^2.6.0`. Co-authored-by: Justin Fagnani <justinfagnani@google.com> Co-authored-by: Steve Orvell <sorvell@google.com> Co-authored-by: Abraham Williams <4braham@gmail.com> Co-authored-by: Peter Burns <rictic@google.com> Co-authored-by: Abdón Rodríguez Davila <a@abdonrd.com> Co-authored-by: Lukas Papay <papay.lukas@gmail.com> Co-authored-by: Arthur Evans <arthure@google.com> Co-authored-by: nicolejadeyee <nicolejadeyee@gmail.com> Co-authored-by: Paul Kinlan <paul.kinlan@gmail.com> Co-authored-by: 0xflotus <0xflotus@gmail.com> Co-authored-by: Felix Schulze Sindern <47390169+FelixSchuSi@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: vikerman <vikerman@users.noreply.github.com> Co-authored-by: Manuel Martín <manuel.martin@gmail.com> Co-authored-by: tikotus <jahvenni@gmail.com> Co-authored-by: Nicolás Font <nicolasfont@gmail.com> Co-authored-by: Vadim Filimonov <philimonovvadim@gmail.com> Co-authored-by: Elliott Marquez <emarquez@google.com> Co-authored-by: Kevin Schaaf <kschaaf@google.com> Co-authored-by: Todd Pressley <todd.pressley1@gmail.com> Co-authored-by: Elliott Marquez <me@elliottmarquez.dev>

google-cla bot added the cla: yes label Mar 5, 2021

e111077 mentioned this pull request Mar 5, 2021

feat: enable forwards compat for lit1 directives #1653

Closed

e111077 marked this pull request as ready for review March 5, 2021 04:44

e111077 requested a review from justinfagnani as a code owner March 5, 2021 04:44

e111077 requested review from rictic, sorvell and kevinpschaaf March 5, 2021 04:44

feat(directives): add forward compat with lit-next

e8c67f9

e111077 force-pushed the lit1-lit2-forward-compat branch from 2f731ba to e8c67f9 Compare March 12, 2021 18:14

Elliott Marquez added 5 commits March 12, 2021 10:23

chore: fix build

587830a

chore: format

d160efd

refactor: type => interface

beeb5ba

chore: format

3ba0c1e

chore: silence unecessary lint

8be8c3f

kevinpschaaf reviewed Mar 17, 2021

View reviewed changes

src/directive.ts Outdated Show resolved Hide resolved

src/async-directive.ts Outdated Show resolved Hide resolved

src/directive.ts Show resolved Hide resolved

feat: add directive-helpers and refactor

4367add

bicknellr reviewed Mar 17, 2021

View reviewed changes

src/directive-helpers.ts Outdated Show resolved Hide resolved

Elliott Marquez added 4 commits March 17, 2021 16:11

refactor: remove getRenderedNodes

590f10b

feat: add start|endNode to ChildPart

1b999ff

chore:Format

ad4790a

docs(async-dir): clarify connect callbacks

07228eb

kevinpschaaf previously approved these changes Mar 18, 2021

View reviewed changes

src/async-directive.ts Outdated Show resolved Hide resolved

src/async-directive.ts Show resolved Hide resolved

justinfagnani requested changes Mar 18, 2021

View reviewed changes

Update src/async-directive.ts

ad67ca7

Co-authored-by: Kevin Schaaf <kschaaf@google.com>

e111077 dismissed kevinpschaaf’s stale review via ad67ca7 March 18, 2021 20:38

Elliott Marquez and others added 4 commits March 18, 2021 15:59

Update src/async-directive.ts

adcaf6f

Co-authored-by: Kevin Schaaf <kschaaf@google.com>

implement suggestions

fabc9f5

chore: run formatter

64ae01d

docs: add jsdoc for directive

bd765ba

bicknellr reviewed Mar 24, 2021

View reviewed changes

src/directive-helpers.ts Show resolved Hide resolved

Update src/directive-helpers.ts

4522dd5

Co-authored-by: Russell Bicknell <bicknellr@google.com>

justinfagnani requested changes Mar 30, 2021

View reviewed changes

src/directive.ts Show resolved Hide resolved

Elliott Marquez added 2 commits March 30, 2021 19:11

test: add migration directive tests

ce6a7ed

chore: format

896fa41

e111077 changed the title ~~feat: lit2 forward-compat directives~~ [lit-html] add Lit 2 directive syntax to Lit 1 Mar 31, 2021

sorvell requested changes Mar 31, 2021

View reviewed changes

src/async-directive.ts Outdated Show resolved Hide resolved

src/directive.ts Outdated Show resolved Hide resolved

src/test/directives/migration-directives_test.ts Show resolved Hide resolved

chore: implement suggestions

491bc66

e111077 requested review from sorvell and justinfagnani March 31, 2021 22:00

chore: run the formatter

c7911ef

sorvell previously approved these changes Apr 1, 2021

View reviewed changes

kevinpschaaf previously approved these changes Apr 1, 2021

View reviewed changes

justinfagnani requested changes Apr 2, 2021

View reviewed changes

chore: implement suggestions

60f2501

e111077 dismissed stale reviews from kevinpschaaf and sorvell via 60f2501 April 2, 2021 02:19

docs: add directive behavior deviation note

f7f1616

e111077 requested a review from justinfagnani April 2, 2021 02:23

justinfagnani previously approved these changes Apr 2, 2021

View reviewed changes

chore: format

dfe7b87

e111077 dismissed justinfagnani’s stale review via dfe7b87 April 2, 2021 04:47

justinfagnani approved these changes Apr 2, 2021

View reviewed changes

e111077 merged commit c60ba47 into master Apr 2, 2021

e111077 deleted the lit1-lit2-forward-compat branch April 2, 2021 04:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[lit-html] add Lit 2 directive syntax to Lit 1 #1654

[lit-html] add Lit 2 directive syntax to Lit 1 #1654

e111077 commented Mar 5, 2021 •

edited

Loading

kevinpschaaf left a comment

kevinpschaaf commented Mar 17, 2021

kevinpschaaf left a comment

justinfagnani left a comment

sorvell left a comment

e111077 commented Apr 2, 2021

e111077 commented Apr 2, 2021

[lit-html] add Lit 2 directive syntax to Lit 1 #1654

[lit-html] add Lit 2 directive syntax to Lit 1 #1654

Conversation

e111077 commented Mar 5, 2021 • edited Loading

kevinpschaaf left a comment

Choose a reason for hiding this comment

kevinpschaaf commented Mar 17, 2021

kevinpschaaf left a comment

Choose a reason for hiding this comment

justinfagnani left a comment

Choose a reason for hiding this comment

sorvell left a comment

Choose a reason for hiding this comment

e111077 commented Apr 2, 2021

e111077 commented Apr 2, 2021

e111077 commented Mar 5, 2021 •

edited

Loading