-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: If finviz doesnt have ratings table ticker_full_info() fails #65
Comments
It seems |
I really appreciate it. Nice package. Thanks for it. -Chris
…On Fri, Feb 3, 2023 at 2:18 PM Tianning Li ***@***.***> wrote:
It seems ACON has no outer rating. I will fix it.
—
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQAOI2SJ4AGIMYAR4MUOIXTWVVR2BANCNFSM6AAAAAAUQUWNIQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Also, does the library give the Income Statement, Balance sheet and Cash
Flow? Annual and quarterly?
…On Fri, Feb 3, 2023 at 2:18 PM Tianning Li ***@***.***> wrote:
It seems ACON has no outer rating. I will fix it.
—
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQAOI2SJ4AGIMYAR4MUOIXTWVVR2BANCNFSM6AAAAAAUQUWNIQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
The issue is fixed in the latest version. Please upgrade your package. |
Thanks for the update. Im wondering if your package works behind the
paywall of finviz if you have a username and password? I was hoping to
grab the groups/industry performance results premarket but it returns last
nights results until after open.
…On Fri, Feb 3, 2023 at 9:32 PM Tianning Li ***@***.***> wrote:
Closed #65 <#65> as
completed.
—
Reply to this email directly, view it on GitHub
<#65 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQAOI2WDHHRSL7OP5WMUBR3WVXEWBANCNFSM6AAAAAAUQUWNIQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Currently, I am not planning to do that but looking for contributions to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
finvizfinance version checks
I have checked that this issue has not already been reported.
I have confirmed this bug exists on the master branch of finvizfinance.
Reproducible Example
Issue Description
Traceback (most recent call last):
File "C:\Users\chris\AppData\Local\Temp\ipykernel_20800\477896250.py", line 1, in
x2 = x.ticker_full_info()
File "C:\Users\chris\anaconda3\lib\site-packages\finvizfinance\quote.py", line 377, in ticker_full_info
self.ticker_outer_ratings()
File "C:\Users\chris\anaconda3\lib\site-packages\finvizfinance\quote.py", line 233, in ticker_outer_ratings
rows = fullview_ratings_outer.findAll("td", class_="fullview-ratings-inner")
AttributeError: 'NoneType' object has no attribute 'findAll'
Expected Behavior
I think you should have the results return with the ratings with an empty dataframe or a nonetype
Installed Versions
(base) C:\Users\chris>pip show finvizfinance
Name: finvizfinance
Version: 0.14.4
Summary: Finviz Finance. Information downloader.
Home-page: https://github.com/lit26/finvizfinance
Author: Tianning Li
Author-email: ltianningli@gmail.com
License: The MIT License (MIT)
Location: c:\users\chris\anaconda3\lib\site-packages
Requires: bs4, datetime, lxml, pandas, requests
Required-by:
The text was updated successfully, but these errors were encountered: