Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: If finviz doesnt have ratings table ticker_full_info() fails #65

Closed
2 tasks done
ranger9692 opened this issue Feb 3, 2023 · 7 comments
Closed
2 tasks done
Assignees

Comments

@ranger9692
Copy link

finvizfinance version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the master branch of finvizfinance.

Reproducible Example

x = finvizfinance('acon')
x.ticker_full_info()

Issue Description

Traceback (most recent call last):

File "C:\Users\chris\AppData\Local\Temp\ipykernel_20800\477896250.py", line 1, in
x2 = x.ticker_full_info()

File "C:\Users\chris\anaconda3\lib\site-packages\finvizfinance\quote.py", line 377, in ticker_full_info
self.ticker_outer_ratings()

File "C:\Users\chris\anaconda3\lib\site-packages\finvizfinance\quote.py", line 233, in ticker_outer_ratings
rows = fullview_ratings_outer.findAll("td", class_="fullview-ratings-inner")

AttributeError: 'NoneType' object has no attribute 'findAll'

Expected Behavior

I think you should have the results return with the ratings with an empty dataframe or a nonetype

Installed Versions

(base) C:\Users\chris>pip show finvizfinance
Name: finvizfinance
Version: 0.14.4
Summary: Finviz Finance. Information downloader.
Home-page: https://github.com/lit26/finvizfinance
Author: Tianning Li
Author-email: ltianningli@gmail.com
License: The MIT License (MIT)
Location: c:\users\chris\anaconda3\lib\site-packages
Requires: bs4, datetime, lxml, pandas, requests
Required-by:

@tli26
Copy link

tli26 commented Feb 3, 2023

It seems ACON has no outer rating. I will fix it.

@ranger9692
Copy link
Author

ranger9692 commented Feb 3, 2023 via email

@ranger9692
Copy link
Author

ranger9692 commented Feb 3, 2023 via email

@tli26
Copy link

tli26 commented Feb 3, 2023

@lit26
Copy link
Owner

lit26 commented Feb 4, 2023

The issue is fixed in the latest version. Please upgrade your package.

@lit26 lit26 closed this as completed Feb 4, 2023
@lit26 lit26 self-assigned this Feb 4, 2023
@ranger9692
Copy link
Author

ranger9692 commented Feb 7, 2023 via email

@lit26
Copy link
Owner

lit26 commented Feb 9, 2023

Currently, I am not planning to do that but looking for contributions to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants