[URGENT] added page_count attribute in overview class #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliziauddin
changed the title
|
@lit26 can you please review this, if everything is fine then please merge this, as I need this update asap. |
lit26
requested changes
Jul 2, 2023
finvizfinance/screener/overview.py
Outdated
| @@ -34,6 +34,7 @@ def __init__(self): | |||
| v_page=self.v_page, signal="", filter="", ticker="" | |||
| ) | |||
| self._load_setting() | |||
| self.page_count = 0 | |||
finvizfinance/screener/overview.py
Outdated
| @@ -173,7 +174,9 @@ def _get_page(self, soup): | |||
| """Check the page number""" | |||
| try: | |||
| options = soup.find(id="pageSelect").findAll("option") | |||
| return len(options) | |||
| page_count = len(options) | |||
| self.page_count = page_count | |||
There was a problem hiding this comment.
Combine the above and return self.page_count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page Count attribute in screener overview class
Summary
In this PR i've just added page count attribute, so that i can access that value.
Type of Change
No new dependencies are required for this change.