-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bs4 and quote issue #94
Conversation
The current commit does not provide the company name. Suggestion: Add the following code between lines 137 and 139 of finvizfinance/quote.py
|
Updated finvizfinance 0.14.7rc2 AND beatufifulsoup4 4.12.2 Screener works for me now. |
Subject: Variable Name Change from Review: Hey there @lit26 , I just noticed the change from
While "Section" seems to convey a similar idea as "Sector" it might confuse people who are used to the old naming. Can you share why you made the change and whether it enhances clarity?
Adding a brief note in the code or updating the documentation could be a helpful addition. When there's a public release, it will help everyone understand what's going on and why.
Perhaps, you could review the codebase to ensure that this variable name change doesn't have unintended consequences or break any existing functionality or code that relies on
Does this project follow a specific naming convention or style guide? If so, does this change align with it? Consistency in naming is crucial for maintaining a clean and easy-to-work-on codebase.
Sharing your thoughts on changes like these with the other contributors can help prevent confusion and ensure everyone is on the same page. I totally understand that we all have different preferences when it comes to coding. I'm just looking to understand the reasoning behind the change and make sure it doesn't cause any hiccups. However, discussing these changes openly can help improve the project for everyone. Looking forward to hearing your thoughts on this! Thanks for your work on the project. Cheers, |
I think this is changed by mistake. Will fix it. |
Description
Fix #90 #92
Type of change
What you did