Shut down the robot on XMPP parse errors.

litaio · May 7, 2015 · 36e585d · 36e585d
1 parent e706627
commit 36e585d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/lita/adapters/hipchat/connector.rb b/lib/lita/adapters/hipchat/connector.rb
@@ -28,6 +28,7 @@ def jid
         end
 
         def connect
+          register_exception_handler
           client_connect
           load_roster
           register_message_callback
@@ -114,6 +115,12 @@ def client_connect
           client.auth(@password)
         end
 
+        def register_exception_handler
+          client.on_exception do |error, connection, error_source|
+            robot.shut_down
+          end
+        end
+
         def register_message_callback
           Callback.new(robot, roster).private_message(client)
         end

diff --git a/spec/lita/adapters/hipchat/connector_spec.rb b/spec/lita/adapters/hipchat/connector_spec.rb
@@ -9,6 +9,7 @@
     allow(client).to receive(:auth)
     allow(client).to receive(:connect)
     allow(client).to receive(:send)
+    allow(client).to receive(:on_exception)
     client
   end
 
@@ -97,6 +98,11 @@
       expect(robot).to receive(:mention_name=).with("LitaBot")
       subject.connect
     end
+
+    it "registers an error handler with the XMPP client" do
+      expect(client).to receive(:on_exception)
+      subject.connect
+    end
   end
 
   describe "#join" do