Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Windows command check #62

Open
takase1121 opened this issue May 12, 2023 · 0 comments
Open

Broken Windows command check #62

takase1121 opened this issue May 12, 2023 · 0 comments

Comments

@takase1121
Copy link
Member

On Windows, these extensions are executable: .exe, .bat, .cmd. However, symbolic links to executables are also executable, so stuff like lite-xl linked to lite-xl.exe is automatically executable.

There is not a good way to do this unless relying on a Win32 function. But I think these extensions should be considered as well.

jgmdev added a commit to jgmdev/lsp that referenced this issue Feb 14, 2024
Besides checking for .exe files we now check for .cmd and .bat files as
reported on lite-xl/lite-xl-lsp#62 This commit also:

* Uses new system.setenv to add /usr/local/bin to path if missing on
  MacOS
* When logging using utils check if log file was successfully opened
  before trying to write into it.
* If value returned by os.getenv is nil set result to empty string
jgmdev added a commit to pragtical/lsp that referenced this issue Feb 14, 2024
Besides checking for .exe files we now check for .cmd and .bat files as
reported on lite-xl/lite-xl-lsp#62 This commit also:

* Uses new system.setenv to add /usr/local/bin to path if missing on
  MacOS
* When logging using utils check if log file was successfully opened
  before trying to write into it.
* If value returned by os.getenv is nil set result to empty string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant