-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin: sorting, filtering, selection fixes #146
base: master
Are you sure you want to change the base?
Conversation
Screencast_20241130_212835.webmMore things to discuss:
|
|
fea63c9
to
1221811
Compare
1221811
to
d269d5b
Compare
I made ctrl+f use filter, and implemented escape to clear filter text, and preserves filter text on subsequent ctrl+f. As for the filtered status, I personally don't like putting messages that should be long running on the StatusView. Sure it is for that purpose but people easily miss it (for example, the find next press F3 thing). I instead put it on the top of the table. Screencast_20241202_145120.webm(Note: the offsetted entries are fixed in the latest commit) |
This ended up a bit larger than I think, so I would love to have another pair of eyes looking at this before getting it merged.