-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api/system: make stat() call consistent across platforms #1864
Conversation
Awesome! With this we could also scale back the |
I am not sure but that should be enough for most use cases. There are also problems with resolution (IIRC all the platforms we are currently supporting won't have this particular issue, though I wouldn't rely on that if I definitively need to know if the system supports high resolution time. |
a9379f2
to
31593b3
Compare
31593b3
to
83ee92f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that on non-windows it's possible for type
to be nil
.
We should either avoid that, or update the documentation.
Can you explain how this would be the case? UPDATE: misread |
Avoid that doesn't sound good. I can update the documentation. |
Includes #1826.
This PR uses GetFileAttributesExW on Windows to get everything we need for get_file_info(), including
symlink
. All platforms will now havesymlink
and high-resolution timestamps if supported. This should help with #1862.