Minify assets before publishing #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for minifying assets before publishing.
This is completely optional for developers and website contributors.
You don't need to download node and these packages if you don't want to.
esbuild and postcss are used to minify the js and css files.
esbuild is famous for being really, really fast and in this case it took (in average) 3ms to minify our js file.
postcss is not that fast, but it is still under a second.
The benefit of this approach is that developers doesn't need to concern themselves with the file size; feel free to make your code as readable and use modern syntax.
These modern syntax will then be compiled into compatible code.
Most developers are already using the latest browsers, so their browser can already run those new features; now they don't have to hold back.
I also added autoprefixer to the mix so that developers don't have to write vendor-prefixed css in the future.
Squash if merge.