🚀[Release v2.12.2 20241118] Merge into Main #273

kcw-grunt · 2024-11-18T14:28:29Z

Release Candidate

Overview

This release has many bugfixes and removes the donation button

Notes

fix: prevent activity close
[fix: https://github.com/🐛[Bug Report]: Crash com.breadwallet.presenter.fragments.FragmentTransactionItem.fillTexts #265[] add null checking
Removed donation button

* replaced the control in PeerManager.c Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * reverted BRBitcoinAmount Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Cleaning up the files Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed Pusher remnants Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

* Added fiat feature based on language user chose * added fcm for push notifications * Update PushNotificationService.kt * Added new Icon, removed duplicate fcm library, added in app messaging * Added new Icon, removed duplicate fcm library, added in app messaging

* Recent newline Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * AF added Refactored cruft - AF working Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

* Tech debt/add af sdk (#248) - AF working - Changed requiredActivity - Added analytics error report - test this.Activity is null or not - Bugfix - Phrase Reminder crash - added an exception handler for UserNotAuthenticatedException. - note: this should allow for the system to display the native authorization UI when needed - fixes issue - https://console.firebase.google.com/u/0/project/litewallet-beta/crashlytics/app/android:com.loafwallet/issues/09dac17241309f0e823ef597a9a82cd4 - Added dev note - remove calls to BREventManager - removed BREventManager - renamed error message - fixed Firebase Analytics event error Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * version bump update gitignore Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

* removed unused BRSharedPreferences Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * started commenting out more Timber Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Added more shared preferences for syncing Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Commented out many verbose Timber logs Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * WIP Still trying to figure out the eplased time and last and start timestamps…??? I dunno Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Moved sync measurment into the method calls Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Debugged the install issue with send - Moved all the measurements in new methods - recalculated measure points - Added analytics - event did_complete_sync was shown! - adding a dummy file to make sure file system is set ||||WIP still verifying the JSON is present - added a blockheight label - changed the sleep time (a hack to allow the device time to refresh the view) to 100 ms from 500ms!! -WIP Why is the bundle not showing on time Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * replaces afID to first location Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed redundant sync measurements Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * code bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

* Removed non english seed words -Refactor tests - Reset AnalyticsTests Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Rename Bitcoinletter to Litecoinletters -added tests testLitecoinSymbolConstants testAppExternalURLConstants testFirebaseAnalyticsConstants Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

…nsaction from androidx (#260)

…Phrase, so we just wrap with runCatching for now to avoid crash (#263)

Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

removed xml removed fragments removed references of the donation removed analytical events Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

* fix: [WIP][#265] work in progress add null checking, migrate viewpager to viewpager2 and more * fix: [#265] finalize migration some deprecated class and implement null checking at FragmentTransactionItem * fix: dix dismiss outside FragmentTransactionDetails

Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

josikie

Looks like we have new set of tests. Thank you! @kcw-grunt

andhikayuana · 2024-11-19T03:57:14Z

will check it again

andhikayuana · 2024-11-20T10:09:17Z

app/src/main/java/com/breadwallet/tools/util/PushNotificationService.kt

+            }
+
+            // Get new FCM registration token
+            val token = task.result


so this is not sending the token to the server?

No @andhikayuana . This was just the basic implementation. We do need to clean up and refactor

andhikayuana · 2024-11-20T10:14:44Z

app/build.gradle

@@ -313,7 +318,8 @@ dependencies {

    // push notifications
    implementation 'com.google.firebase:firebase-messaging:23.4.0'
-    implementation 'com.pusher:push-notifications-android:1.9.0'
+    implementation("com.google.firebase:firebase-inappmessaging-display")


wondering, why we use this firebase-inappmessaging?

We want to have Inapp and cloud messaging for both here (Android) and iOS. We haven't implemented it properly and you see some of the remnants of our efforts. Once we retire these major bugs we can start looking at adding FEATURES 😄 @andhikayuana

andhikayuana · 2024-11-20T10:18:04Z

app/src/main/AndroidManifest.xml

@@ -224,6 +224,18 @@
            android:enabled="true"
            android:exported="false"
            android:label="SyncReceiver" />
+


could you explain more context on this FCM usage?
if we need to display notification, we need to add notification permission since API 33 and add notification channel since API 26

Agreed @andhikayuana this was not fully/correctly implemented. We need to fix this in the next release

andhikayuana · 2024-11-20T10:21:13Z

app/src/androidTest/java/com/litewallet/analytics/ConstantsTests.java

+import java.net.URI;
+
+@RunWith(AndroidJUnit4.class)
+public class ConstantsTests {


since this is not UI test, we can move it to app/src/test instead of app/src/androidTest and using JUnit with mockk.
probably I will help to setup the testing stuff on the next PR

Thanks @andhikayuana

Added: #280

cc: @josikie

* 🚀[Release v2.11.1 071024] Merge into Develop (#245) * replaced the control in PeerManager.c Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * reverted BRBitcoinAmount Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Cleaning up the files Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed Pusher remnants Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Added Fiat feature, and FCM for push notifications (#247) * Added fiat feature based on language user chose * added fcm for push notifications * Update PushNotificationService.kt * Added new Icon, removed duplicate fcm library, added in app messaging * Added new Icon, removed duplicate fcm library, added in app messaging * Tech debt/add af sdk (#248) * Recent newline Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * AF added Refactored cruft - AF working Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Techdebt/refactor brevents syncmarkers (#254) * Tech debt/add af sdk (#248) - AF working - Changed requiredActivity - Added analytics error report - test this.Activity is null or not - Bugfix - Phrase Reminder crash - added an exception handler for UserNotAuthenticatedException. - note: this should allow for the system to display the native authorization UI when needed - fixes issue - https://console.firebase.google.com/u/0/project/litewallet-beta/crashlytics/app/android:com.loafwallet/issues/09dac17241309f0e823ef597a9a82cd4 - Added dev note - remove calls to BREventManager - removed BREventManager - renamed error message - fixed Firebase Analytics event error Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * version bump update gitignore Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Techdebt/ fixed send issue add syncing measurements (#255) * removed unused BRSharedPreferences Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * started commenting out more Timber Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Added more shared preferences for syncing Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Commented out many verbose Timber logs Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * WIP Still trying to figure out the eplased time and last and start timestamps…??? I dunno Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Moved sync measurment into the method calls Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Debugged the install issue with send - Moved all the measurements in new methods - recalculated measure points - Added analytics - event did_complete_sync was shown! - adding a dummy file to make sure file system is set ||||WIP still verifying the JSON is present - added a blockheight label - changed the sleep time (a hack to allow the device time to refresh the view) to 100 ms from 500ms!! -WIP Why is the bundle not showing on time Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * replaces afID to first location Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed redundant sync measurements Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * code bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Techdebt/test refactor cruft removal (#250) * Removed non english seed words -Refactor tests - Reset AnalyticsTests Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Rename Bitcoinletter to Litecoinletters -added tests testLitecoinSymbolConstants testAppExternalURLConstants testFirebaseAnalyticsConstants Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * fix: [#152] make sure using Fragment, FragmentManager and FragmentTransaction from androidx (#260) * fix: [#126] the issue came from FragmentBalanceSeedReminder.fetchSeedPhrase, so we just wrap with runCatching for now to avoid crash (#263) * version bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed donation button removed xml removed fragments removed references of the donation removed analytical events Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * fix: prevent activity close * code bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * enabled for Debug Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * fix: [#264] add null checking for BRKeyStore.removeAliasAndFiles (#270) * fix: [#265] add null checking, migrate viewpage… (#271) * fix: [WIP][#265] work in progress add null checking, migrate viewpager to viewpager2 and more * fix: [#265] finalize migration some deprecated class and implement null checking at FragmentTransactionItem * fix: dix dismiss outside FragmentTransactionDetails * code bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * version bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> Co-authored-by: Josi Kie <54074780+josikie@users.noreply.github.com> Co-authored-by: Andhika Yuana <andhikayuana@gmail.com>

@andhikayuana

* 🚀[Release v2.11.1 071024] Merge into Main (#246) * replaced the control in PeerManager.c Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * reverted BRBitcoinAmount Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Cleaning up the files Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed Pusher remnants Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * 🚀[Release v2.12.2 20241118] Merge into Main (#273) * 🚀[Release v2.11.1 071024] Merge into Develop (#245) * replaced the control in PeerManager.c Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * reverted BRBitcoinAmount Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Cleaning up the files Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed Pusher remnants Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Added Fiat feature, and FCM for push notifications (#247) * Added fiat feature based on language user chose * added fcm for push notifications * Update PushNotificationService.kt * Added new Icon, removed duplicate fcm library, added in app messaging * Added new Icon, removed duplicate fcm library, added in app messaging * Tech debt/add af sdk (#248) * Recent newline Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * AF added Refactored cruft - AF working Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Techdebt/refactor brevents syncmarkers (#254) * Tech debt/add af sdk (#248) - AF working - Changed requiredActivity - Added analytics error report - test this.Activity is null or not - Bugfix - Phrase Reminder crash - added an exception handler for UserNotAuthenticatedException. - note: this should allow for the system to display the native authorization UI when needed - fixes issue - https://console.firebase.google.com/u/0/project/litewallet-beta/crashlytics/app/android:com.loafwallet/issues/09dac17241309f0e823ef597a9a82cd4 - Added dev note - remove calls to BREventManager - removed BREventManager - renamed error message - fixed Firebase Analytics event error Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * version bump update gitignore Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Techdebt/ fixed send issue add syncing measurements (#255) * removed unused BRSharedPreferences Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * started commenting out more Timber Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Added more shared preferences for syncing Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Commented out many verbose Timber logs Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * WIP Still trying to figure out the eplased time and last and start timestamps…??? I dunno Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Moved sync measurment into the method calls Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Debugged the install issue with send - Moved all the measurements in new methods - recalculated measure points - Added analytics - event did_complete_sync was shown! - adding a dummy file to make sure file system is set ||||WIP still verifying the JSON is present - added a blockheight label - changed the sleep time (a hack to allow the device time to refresh the view) to 100 ms from 500ms!! -WIP Why is the bundle not showing on time Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * replaces afID to first location Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed redundant sync measurements Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * code bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Techdebt/test refactor cruft removal (#250) * Removed non english seed words -Refactor tests - Reset AnalyticsTests Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Rename Bitcoinletter to Litecoinletters -added tests testLitecoinSymbolConstants testAppExternalURLConstants testFirebaseAnalyticsConstants Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * fix: [#152] make sure using Fragment, FragmentManager and FragmentTransaction from androidx (#260) * fix: [#126] the issue came from FragmentBalanceSeedReminder.fetchSeedPhrase, so we just wrap with runCatching for now to avoid crash (#263) * version bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed donation button removed xml removed fragments removed references of the donation removed analytical events Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * fix: prevent activity close * code bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * enabled for Debug Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * fix: [#264] add null checking for BRKeyStore.removeAliasAndFiles (#270) * fix: [#265] add null checking, migrate viewpage… (#271) * fix: [WIP][#265] work in progress add null checking, migrate viewpager to viewpager2 and more * fix: [#265] finalize migration some deprecated class and implement null checking at FragmentTransactionItem * fix: dix dismiss outside FragmentTransactionDetails * code bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * version bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> Co-authored-by: Josi Kie <54074780+josikie@users.noreply.github.com> Co-authored-by: Andhika Yuana <andhikayuana@gmail.com> * bumped version and code * compiled the env (#284) please check @andhikayuana @josikie that you are able to compile * Users complained that recyclerView was setting to the wrong language - Polished to index to a language - bump code * chore: [#126] simplify exception handling at BRKeyStore._getData and record exception to Firebase Crashlytics (#283) --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> Co-authored-by: Josi Kie <54074780+josikie@users.noreply.github.com> Co-authored-by: Andhika Yuana <andhikayuana@gmail.com>

@andhikayuana

* 🚀[Release v2.11.1 071024] Merge into Develop (#245) * replaced the control in PeerManager.c Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * reverted BRBitcoinAmount Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Cleaning up the files Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed Pusher remnants Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Added Fiat feature, and FCM for push notifications (#247) * Added fiat feature based on language user chose * added fcm for push notifications * Update PushNotificationService.kt * Added new Icon, removed duplicate fcm library, added in app messaging * Added new Icon, removed duplicate fcm library, added in app messaging * Tech debt/add af sdk (#248) * Recent newline Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * AF added Refactored cruft - AF working Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Techdebt/refactor brevents syncmarkers (#254) * Tech debt/add af sdk (#248) - AF working - Changed requiredActivity - Added analytics error report - test this.Activity is null or not - Bugfix - Phrase Reminder crash - added an exception handler for UserNotAuthenticatedException. - note: this should allow for the system to display the native authorization UI when needed - fixes issue - https://console.firebase.google.com/u/0/project/litewallet-beta/crashlytics/app/android:com.loafwallet/issues/09dac17241309f0e823ef597a9a82cd4 - Added dev note - remove calls to BREventManager - removed BREventManager - renamed error message - fixed Firebase Analytics event error Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * version bump update gitignore Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Techdebt/ fixed send issue add syncing measurements (#255) * removed unused BRSharedPreferences Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * started commenting out more Timber Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Added more shared preferences for syncing Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Commented out many verbose Timber logs Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * WIP Still trying to figure out the eplased time and last and start timestamps…??? I dunno Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Moved sync measurment into the method calls Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Debugged the install issue with send - Moved all the measurements in new methods - recalculated measure points - Added analytics - event did_complete_sync was shown! - adding a dummy file to make sure file system is set ||||WIP still verifying the JSON is present - added a blockheight label - changed the sleep time (a hack to allow the device time to refresh the view) to 100 ms from 500ms!! -WIP Why is the bundle not showing on time Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * replaces afID to first location Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed redundant sync measurements Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * code bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Techdebt/test refactor cruft removal (#250) * Removed non english seed words -Refactor tests - Reset AnalyticsTests Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Rename Bitcoinletter to Litecoinletters -added tests testLitecoinSymbolConstants testAppExternalURLConstants testFirebaseAnalyticsConstants Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * fix: [#152] make sure using Fragment, FragmentManager and FragmentTransaction from androidx (#260) * fix: [#126] the issue came from FragmentBalanceSeedReminder.fetchSeedPhrase, so we just wrap with runCatching for now to avoid crash (#263) * fix: [#264] add null checking for BRKeyStore.removeAliasAndFiles (#270) * fix: [#265] add null checking, migrate viewpage… (#271) * fix: [WIP][#265] work in progress add null checking, migrate viewpager to viewpager2 and more * fix: [#265] finalize migration some deprecated class and implement null checking at FragmentTransactionItem * fix: dix dismiss outside FragmentTransactionDetails * 🚀[Release v2.12.2 20241118] Merge into Develop (#272) * 🚀[Release v2.11.1 071024] Merge into Main (#246) * replaced the control in PeerManager.c Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * reverted BRBitcoinAmount Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Cleaning up the files Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed Pusher remnants Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * version bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed donation button removed xml removed fragments removed references of the donation removed analytical events Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * fix: prevent activity close * code bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * enabled for Debug Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * fix: [#264] add null checking for BRKeyStore.removeAliasAndFiles (#270) * fix: [#265] add null checking, migrate viewpage… (#271) * fix: [WIP][#265] work in progress add null checking, migrate viewpager to viewpager2 and more * fix: [#265] finalize migration some deprecated class and implement null checking at FragmentTransactionItem * fix: dix dismiss outside FragmentTransactionDetails * code bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * version bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> Co-authored-by: andhikayuana <andhikayuana@gmail.com> * revert minSDkVersion to 29 (#276) Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * fix: [#258] avoid OOM with cache the result of opsAll, previously called multiple times at onBindViewHolder (#277) * fix: [#258] avoid OOM with cache the result of opsAll, previously called multiple times at onBindViewHolder * chore: [#258] cleanup comment * fix: [#266] add null checking and default value based on iOS since getCurrency can produce null (#278) * fix: [#266] add null checking and default value based on iOS since getCurrency can produce null * chore: [#266] cleanup comment * fix: [#274] fixing locale on android 14 and setup test using junit & mockk (#282) * chore: [#274] initial setup test using JUnit & MockK * chore: [#274] add more test case at LocaleHelperTest * fix: [#274] fix default language from shared preferences * fix: [#274] disable language split on AAB * chore: [#274] rename method * chore: [#126] simplify exception handling at BRKeyStore._getData and record exception to Firebase Crashlytics (#283) * Techdebt/remove auth prompt (#256) * Check reenter pin freeze after the auth prompt deleted. Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * cleaned up deletion Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Many removals - Removed the fingerprint xml - Removed the Fingerprint Fragment and java files - Removed the enum referencing the fingerprint prompt - Removed check of fingerprint enrollment and checks - Removed biometrics and fingerprint permissions Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * removed fingerprint image code and version bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * chore: remove FragmentFingerprint.java since, not used and failed to build --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> Co-authored-by: josikie <kiejosi12@gmail.com> Co-authored-by: andhikayuana <andhikayuana@gmail.com> * 🚀[Release v2.12.4 20241130] Merge into Develop (#286) * 🚀[Release v2.11.1 071024] Merge into Main (#246) * replaced the control in PeerManager.c Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * reverted BRBitcoinAmount Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Cleaning up the files Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed Pusher remnants Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * 🚀[Release v2.12.2 20241118] Merge into Main (#273) * 🚀[Release v2.11.1 071024] Merge into Develop (#245) * replaced the control in PeerManager.c Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * reverted BRBitcoinAmount Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Cleaning up the files Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed Pusher remnants Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Added Fiat feature, and FCM for push notifications (#247) * Added fiat feature based on language user chose * added fcm for push notifications * Update PushNotificationService.kt * Added new Icon, removed duplicate fcm library, added in app messaging * Added new Icon, removed duplicate fcm library, added in app messaging * Tech debt/add af sdk (#248) * Recent newline Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * AF added Refactored cruft - AF working Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Techdebt/refactor brevents syncmarkers (#254) * Tech debt/add af sdk (#248) - AF working - Changed requiredActivity - Added analytics error report - test this.Activity is null or not - Bugfix - Phrase Reminder crash - added an exception handler for UserNotAuthenticatedException. - note: this should allow for the system to display the native authorization UI when needed - fixes issue - https://console.firebase.google.com/u/0/project/litewallet-beta/crashlytics/app/android:com.loafwallet/issues/09dac17241309f0e823ef597a9a82cd4 - Added dev note - remove calls to BREventManager - removed BREventManager - renamed error message - fixed Firebase Analytics event error Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * version bump update gitignore Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Techdebt/ fixed send issue add syncing measurements (#255) * removed unused BRSharedPreferences Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * started commenting out more Timber Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Added more shared preferences for syncing Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Commented out many verbose Timber logs Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * WIP Still trying to figure out the eplased time and last and start timestamps…??? I dunno Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Moved sync measurment into the method calls Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Debugged the install issue with send - Moved all the measurements in new methods - recalculated measure points - Added analytics - event did_complete_sync was shown! - adding a dummy file to make sure file system is set ||||WIP still verifying the JSON is present - added a blockheight label - changed the sleep time (a hack to allow the device time to refresh the view) to 100 ms from 500ms!! -WIP Why is the bundle not showing on time Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * replaces afID to first location Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed redundant sync measurements Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * code bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Techdebt/test refactor cruft removal (#250) * Removed non english seed words -Refactor tests - Reset AnalyticsTests Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Rename Bitcoinletter to Litecoinletters -added tests testLitecoinSymbolConstants testAppExternalURLConstants testFirebaseAnalyticsConstants Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * fix: [#152] make sure using Fragment, FragmentManager and FragmentTransaction from androidx (#260) * fix: [#126] the issue came from FragmentBalanceSeedReminder.fetchSeedPhrase, so we just wrap with runCatching for now to avoid crash (#263) * version bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * Removed donation button removed xml removed fragments removed references of the donation removed analytical events Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * fix: prevent activity close * code bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * enabled for Debug Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * fix: [#264] add null checking for BRKeyStore.removeAliasAndFiles (#270) * fix: [#265] add null checking, migrate viewpage… (#271) * fix: [WIP][#265] work in progress add null checking, migrate viewpager to viewpager2 and more * fix: [#265] finalize migration some deprecated class and implement null checking at FragmentTransactionItem * fix: dix dismiss outside FragmentTransactionDetails * code bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * version bump Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> Co-authored-by: Josi Kie <54074780+josikie@users.noreply.github.com> Co-authored-by: Andhika Yuana <andhikayuana@gmail.com> * bumped version and code * compiled the env (#284) please check @andhikayuana @josikie that you are able to compile * Users complained that recyclerView was setting to the wrong language - Polished to index to a language - bump code * chore: [#126] simplify exception handling at BRKeyStore._getData and record exception to Firebase Crashlytics (#283) --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> Co-authored-by: Josi Kie <54074780+josikie@users.noreply.github.com> Co-authored-by: Andhika Yuana <andhikayuana@gmail.com> * Added abilities to copy transaction id by click the transaction id (#290) * Added abilities to copy transaction id by click the transaction id * Update build.gradle * version and code bump * Unit Test(s) Migration (#287) * chore: [test] add BRConstantsTest for unitTest and deprecated ConstantsTests inside androidTest * chore: [test] remove unused test files * chore: [test] add todo to fill the tests and change package name * chore: [test] add basic example * chore: [test] integrate with ci/cd * chore: [test][ci] fix Cannot find a definition for command named android/restore-gradle-cache * chore: [test][ci] fix Cannot find a definition for command named android/run-tests * chore: [test][ci] fix Unexpected argument(s): test-command * chore: [test][ci] fix Cannot find a definition for executor named android/android-docker * chore: [test][ci] add default for gradle.properties * chore: [test][ci] avoid breaking in build.gradle * chore: [test][ci] enable androidx and jetifier * chore: [test][ci] init submodule * chore: [test][ci] just using run command for execute unit test step * chore: [test][ci] add env for google-services.json * chore: [test][ci] add env for google-services.json * chore: [test][ci] add env for google-services.json * Major refactor of code to move classes to the ideal location - Removed cruft - Moved all tests to the unitTest directory - Remove poorly placed tests into (AndroidTest) - Commented old code into the new Kotlin class(es) - working in the first test of currency - Removed the paymentRequest method - Renamed Classes * chore: resolve CurrencyTests * Added notes --------- Co-authored-by: Kerry Washington <mrkerrywashington@icloud.com> * feat: remote config feature toggle (#293) * feat: [remote-config] wip for remote config feature toggle * feat: [remote-config] implement base url toggle for prod and dev * feat: [test] add BRApiManagerTest * fix: fix getBaseUrlProd for FragmentBuy and add test * chore: change BRApiManager.fetchRates using getBaseUrlProd * version and code bump * Update .gitignore --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> Co-authored-by: Josi Kie <54074780+josikie@users.noreply.github.com> Co-authored-by: Andhika Yuana <andhikayuana@gmail.com> Co-authored-by: josikie <kiejosi12@gmail.com>

kcw-grunt and others added 17 commits October 7, 2024 18:10

Tech debt/add af sdk (#248)

41b3970

* Recent newline Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> * AF added Refactored cruft - AF working Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com> --------- Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

fix: [#152] make sure using Fragment, FragmentManager and FragmentTra…

5b6f95e

…nsaction from androidx (#260)

fix: [#126] the issue came from FragmentBalanceSeedReminder.fetchSeed…

30c446d

…Phrase, so we just wrap with runCatching for now to avoid crash (#263)

version bump

22e2b9d

Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

Removed donation button

837c924

removed xml removed fragments removed references of the donation removed analytical events Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

fix: prevent activity close

6d72edf

code bump

e9131b8

Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

enabled for Debug

82f6215

Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

fix: [#264] add null checking for BRKeyStore.removeAliasAndFiles (#270)

a1fc8ee

code bump

ce1dc07

Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

version bump

6f605b0

Signed-off-by: kcw-grunt <mrkerrywashington@icloud.com>

kcw-grunt changed the title ~~Release/v2.12.2~~ 🚀[Release v2.12.2 20241118] Merge into Main Nov 18, 2024

Merge branch 'main' into release/v2.12.2

3b26769

kcw-grunt self-assigned this Nov 18, 2024

kcw-grunt requested review from josikie and andhikayuana November 18, 2024 14:34

kcw-grunt added android Android related only 🚀 release Related to a production release labels Nov 18, 2024

kcw-grunt added this to the v2.12.X milestone Nov 18, 2024

kcw-grunt marked this pull request as ready for review November 18, 2024 14:35

josikie approved these changes Nov 18, 2024

View reviewed changes

andhikayuana approved these changes Nov 19, 2024

View reviewed changes

andhikayuana self-requested a review November 19, 2024 03:56

andhikayuana reviewed Nov 20, 2024

View reviewed changes

kcw-grunt mentioned this pull request Nov 21, 2024

🦺[Tech Debt]: Refactor placement of Tests structure #280

Open

4 tasks

kcw-grunt merged commit 948008f into main Nov 21, 2024
2 checks passed

kcw-grunt deleted the release/v2.12.2 branch November 21, 2024 15:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🚀[Release v2.12.2 20241118] Merge into Main #273

🚀[Release v2.12.2 20241118] Merge into Main #273

kcw-grunt commented Nov 18, 2024 •

edited

Loading

josikie left a comment

andhikayuana commented Nov 19, 2024

andhikayuana Nov 20, 2024

kcw-grunt Nov 21, 2024

andhikayuana Nov 20, 2024

kcw-grunt Nov 21, 2024

andhikayuana Nov 20, 2024

kcw-grunt Nov 21, 2024

andhikayuana Nov 20, 2024 •

edited

Loading

kcw-grunt Nov 21, 2024 •

edited

Loading

🚀[Release v2.12.2 20241118] Merge into Main #273

🚀[Release v2.12.2 20241118] Merge into Main #273

Conversation

kcw-grunt commented Nov 18, 2024 • edited Loading

Release Candidate

Overview

Notes

josikie left a comment

Choose a reason for hiding this comment

andhikayuana commented Nov 19, 2024

andhikayuana Nov 20, 2024

Choose a reason for hiding this comment

kcw-grunt Nov 21, 2024

Choose a reason for hiding this comment

andhikayuana Nov 20, 2024

Choose a reason for hiding this comment

kcw-grunt Nov 21, 2024

Choose a reason for hiding this comment

andhikayuana Nov 20, 2024

Choose a reason for hiding this comment

kcw-grunt Nov 21, 2024

Choose a reason for hiding this comment

andhikayuana Nov 20, 2024 • edited Loading

Choose a reason for hiding this comment

kcw-grunt Nov 21, 2024 • edited Loading

Choose a reason for hiding this comment

kcw-grunt commented Nov 18, 2024 •

edited

Loading

andhikayuana Nov 20, 2024 •

edited

Loading

kcw-grunt Nov 21, 2024 •

edited

Loading