Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦺 [techdebt] Compiled the env: Normalize for the Android Devs #284

Merged
merged 1 commit into from
Nov 29, 2024
Merged

🦺 [techdebt] Compiled the env: Normalize for the Android Devs #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ android {
// libraries Gradle should build and package with your APK.
abiFilters 'x86', 'x86_64', 'armeabi-v7a', 'arm64-v8a'
}
ndkVersion "25.1.8937393"
externalNativeBuild {
cmake {
version "3.22.1"
arguments "-DANDROID_TOOLCHAIN=clang"
}
}
Expand Down
4 changes: 2 additions & 2 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ buildscript {
// in below line we are adding configurations to our project.
configurations.all {
// in below line we are adding strategy for each dependency and requesting the details
resolutionStrategy.eachDependency {DependencyResolveDetails details ->
resolutionStrategy.eachDependency {details ->
// on below line we are getting to see the details using requested.
def requested = details.requested
// in below line we are requesting a group.
Expand All @@ -29,7 +29,7 @@ buildscript {

// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
classpath 'com.google.gms:google-services:4.4.0'
classpath 'com.google.gms:google-services:4.4.2'

classpath 'com.google.firebase:firebase-crashlytics-gradle:2.9.9'

Expand Down
Binary file modified gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
5 changes: 3 additions & 2 deletions gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#Sat Jan 20 19:11:29 EST 2024
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.2-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10-bin.zip
Copy link
Member Author

@kcw-grunt kcw-grunt Nov 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we go to 8.10 @andhikayuana ?
cc: @josikie

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think yes, it's one of the newest, but is it compatible? @kcw-grunt

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checking on this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, we can go using gradle 8.10.
for now we can keep as is for the android gradle plugin version which is 8.2.1. but the recommendation here https://developer.android.com/build/releases/gradle-plugin#updating-gradle, we should use the latest possible version of both Gradle and the plugin.

to bump up with the latest version of android gradle plugin (AGP), I think we need to create separate PR in the next iteration since we need to make sure with kotlin version compatible and also migrating to .gradle.kts for modern build script.

networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading