Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase origin fees precision #10

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Increase origin fees precision #10

wants to merge 7 commits into from

Conversation

NicolasMahe
Copy link
Member

Simplification of #9

PR NOT TO MERGE

Implement the "per trillion" precision only for origin fees.

To execute the tests:

cd exchange-v2
npm run test

@NicolasMahe NicolasMahe requested a review from antho1404 January 24, 2023 16:08
@NicolasMahe NicolasMahe self-assigned this Jan 24, 2023
@NicolasMahe NicolasMahe mentioned this pull request Jan 24, 2023
Closed
@NicolasMahe NicolasMahe changed the title Feature/increase fees precision 2 Increase origin fees precision Jan 24, 2023
@antho1404
Copy link
Member

Could you deploy it on a chain (I guess goerli is the most needed right now) to run some tests

@NicolasMahe
Copy link
Member Author

NicolasMahe commented Jan 27, 2023 •
edited
Loading

Here are the deployed contracts on goerli:

  • erc721 and erc1155 transfer proxy: 0xe512Be3198381Dc0667B8d796A7487ee80570F8e
  • erc20 transfer proxy: 0x5634b15623Af0bd6B11Cd61Ce287f9F3C47b9249
  • exchange: 0xBa2A7315cAE5cD81F942aF50c1D09b98df1d3C65
  • erc721 factory: 0x7B7aE00a388D3147Ccdf27C37317a80A00b080E7
  • erc1155 factory: 0x99079f610a8CD19C7A05a761B0d4a73A67ee1eD3

@NicolasMahe NicolasMahe force-pushed the feature/increase-fees-precision-2 branch from 24ba6a3 to caa95f7 Compare February 8, 2023 04:24
Base automatically changed from deploy/binance to master February 8, 2023 07:40
@NicolasMahe NicolasMahe marked this pull request as draft February 8, 2023 07:43
@NicolasMahe NicolasMahe removed the request for review from antho1404 February 8, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NicolasMahe NicolasMahe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicolasMahe @antho1404