Revert conditional docker-login step in CI (#3779)

* Revert "Remove condition in docker-login ci (#3776)"

This reverts commit a4a6cdc.

* fix clippy

Author: Kailai-Wang

.github/workflows/ci.yml

@@ -551,12 +551,6 @@ jobs:
         if: startsWith(runner.name, 'GitHub Actions')
         uses: ./.github/actions/disk-cleanup
 
-      - name: Dockerhub login
-        uses: docker/login-action@v3
-        with:
-          username: ${{ secrets.DOCKERHUB_USERNAME }}
-          password: ${{ secrets.DOCKERHUB_PASSWORD }}
-
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
         with:
@@ -576,6 +570,13 @@ jobs:
           build-args: |
             CARGO_FEATURES=mock-server
 
+      - name: Dockerhub login
+        if: needs.set-condition.outputs.rebuild_omni_executor == 'false'
+        uses: docker/login-action@v3
+        with:
+          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_PASSWORD }}
+
       - name: Pull omni-executor image optionally
         if: needs.set-condition.outputs.rebuild_omni_executor == 'false'
         run: |