Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade integritee dependencies to polkadot-v0.9.32 base #1069

Closed
Kailai-Wang opened this issue Dec 6, 2022 · 3 comments · Fixed by #1093 or #1095
Closed

Upgrade integritee dependencies to polkadot-v0.9.32 base #1069

Kailai-Wang opened this issue Dec 6, 2022 · 3 comments · Fixed by #1093 or #1095
Assignees
@BillyWooo @Marky-Shi
Labels
D1-feature A new feature, a piece of functionality that needs to be developed I3-high should be completed within 5 working days

Comments

@Kailai-Wang
Copy link
Collaborator

Context

As agreed with Integritee we'll start to take over the upgrade work of substrate/polkadot dependencies. The changes should be submitted as PRs into the master(default) branch of the corresponding integritee repos, in the following order:

  1. pallets
  2. node
  3. worker

It shouldn't break anything even we do it sequentially as Cargo.lock makes sure it has the matching revision.

Please note:

  • we should only submit the next PR when the previous PR gets reviewed and merged
  • we should only upgrade the dependencies without touching any code logic
  • contact integritee colleagues if we meet any blockers during upgrade and/or need responsive reviews

✔️ Please set appropriate labels and assignees if applicable.
@Kailai-Wang Kailai-Wang added I3-high should be completed within 5 working days D1-feature A new feature, a piece of functionality that needs to be developed labels Dec 6, 2022
@Kailai-Wang
Copy link
Collaborator Author

Btw please add links to PRs when closing this issue

@jingleizhang
Copy link
Contributor

jingleizhang commented Dec 12, 2022 •
edited by Marky-Shi
Loading

The pallets repo is merged

@Marky-Shi
Copy link
Contributor

Marky-Shi commented Dec 15, 2022 •
edited
Loading

node and worker pr is merged

@BillyWooo BillyWooo linked a pull request Dec 15, 2022 that will close this issue
Tee worker polkadot v0.9.32 #1093
Merged
@Kailai-Wang Kailai-Wang linked a pull request Dec 15, 2022 that will close this issue
update tee-worker to polkadot-v0.9.32 and sync with upstream integritee worker #1095
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillyWooo BillyWooo

@Marky-Shi Marky-Shi

Labels
D1-feature A new feature, a piece of functionality that needs to be developed I3-high should be completed within 5 working days
Projects
None yet
Milestone
No milestone
4 participants
@jingleizhang @Kailai-Wang @BillyWooo @Marky-Shi