Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr polkadot v0.9.32 #121

Merged
merged 12 commits into from
Dec 9, 2022
Merged

Conversation

BillyWooo
Copy link
Contributor

upgrade to substrate: polkadot-v0.9.32

  • Only bump up to version v0.9.32
  • 'Origin' -> 'RuntimeOrigin', etc. renaming

@clangenb
Copy link
Contributor

clangenb commented Dec 7, 2022

Hmm, it seems that parity has included a new dependency that is plain GPL-3, how do you suggest we handle this @Niederb?

Can we still be Apache-2? If not, parity can't either, I suppose - haha. I would imagine that parity is simply not aware of this.

@haerdib
Copy link
Contributor

haerdib commented Dec 7, 2022

FYI : paritytech/substrate#12689

@haerdib
Copy link
Contributor

haerdib commented Dec 7, 2022

There's already a new version of array-bytes.. So maybe a patch would solve this problem?

@Niederb
Copy link
Contributor

Niederb commented Dec 7, 2022

@haerdib You are quick 😄
@clangenb Seems that this one is already reported but yeah if our main dependency is not strict with the licensing then there will always be issues popping up.
Our options are quite limited:

  • Reporting it upstream or making PRs ourselves
  • Changing our licensing

@clangenb
Copy link
Contributor

clangenb commented Dec 7, 2022

Patching does not work, you can only patch the same version. As this will be fixed in a future release, I simply suggest to accept the licence violation for now.

@haerdib
Copy link
Contributor

haerdib commented Dec 7, 2022

There's an even simpler solution, I believe: @BillyWooo can you try to run
cargo update -p array-bytes ? That should update it to 4.2, which already includes Apache 2.0 license.

Tested it on the substrate-api-client.

@BillyWooo
Copy link
Contributor Author

cargo update -p array-bytes

Just commit new changes from cargo update -p array-bytes

Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me!

@clangenb clangenb merged commit 35da218 into integritee-network:master Dec 9, 2022
@BillyWooo BillyWooo deleted the pr-polkadot-v0.9.32 branch March 11, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants