Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Crate array-bytes adds GPL 3.0 license dependency to sp-core #12689

Closed
2 tasks done
haerdib opened this issue Nov 11, 2022 · 8 comments
Closed
2 tasks done

Crate array-bytes adds GPL 3.0 license dependency to sp-core #12689

haerdib opened this issue Nov 11, 2022 · 8 comments
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.

Comments

@haerdib
Copy link
Contributor

haerdib commented Nov 11, 2022

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

sp-core, licensed under Apache 2.0, adds a GPL 3.0 license by depending on array-bytes.

To the best of my knowledge (not a lawyer) this violates the GLP 3.0 license.

Steps to reproduce

Noticed this while trying to add a license check to our Apache 2.0 licensed project (https://github.com/scs/substrate-api-client/actions/runs/3443791729/jobs/5745700596)

@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Nov 11, 2022
@aurexav
Copy link
Contributor

aurexav commented Nov 14, 2022

I'll consider changing array-bytes's license to Apache 2.0.

I think I'll update the license tonight.

@bkchr
Copy link
Member

bkchr commented Nov 14, 2022

@AurevoirXavier would be nice if you could do this! Maybe dual licensing also works, but I'm no lawyer :P

@aurexav
Copy link
Contributor

aurexav commented Nov 15, 2022

Maybe a dual license for Apache x GPL is meaningless.

But I did release the restriction.

Anyway, you could use it under Apache-2.0 now.

@haerdib
Copy link
Contributor Author

haerdib commented Nov 15, 2022

Awesome. Thank you very much for the quick reaction !

@aurexav
Copy link
Contributor

aurexav commented Nov 15, 2022

So, I think this could be closed now.

@haerdib
Copy link
Contributor Author

haerdib commented Nov 15, 2022

It's not closed on my end yet, because substrate still depends on the GPL version of array-bytes. A dependency bump will solve it.

@aurexav
Copy link
Contributor

aurexav commented Nov 15, 2022

It's not closed on my end yet, because substrate still depends on the GPL version of array-bytes. A dependency bump will solve it.

It looks like I need to release a new version.

@haerdib
Copy link
Contributor Author

haerdib commented Jan 13, 2023

Closing this, as array-bytes has been bumped to v4.2.0 which includes the Apache 2.0 licence.

substrate/Cargo.lock

Lines 194 to 198 in ad58606

[[package]]
name = "array-bytes"
version = "4.2.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "f52f63c5c1316a16a4b35eaac8b76a98248961a533f061684cb2a7cb0eafb6c6"

@haerdib haerdib closed this as completed Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J2-unconfirmed Issue might be valid, but it’s not yet known.
Projects
None yet
Development

No branches or pull requests

3 participants