-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upstream commit base 922e8733
#2281
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kailai-Wang
added
the
C0-breaking
Breaking change that will cause existing client to break
label
Nov 27, 2023
P-283 Update upstream commit base
I see several interesting commits from upstream - I assume we want them too. Our current code is based at b9c80164 which is 2 months ago. |
kziemianek
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I briefly checked file by file. Looks fine!
BillyWooo
reviewed
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As topic, it includes a significant amount of changes and adjustments.
Notes:
build_and_test.yml
(e.g. separate worker and cli build) but I consider them less suitable for our case, so I didn't apply it to our CIpallets/teerex/src/lib.rs
theblock_number
inconfirm_processed_parentchain_block
is not compact-encoded anymore - to be consistent with upstreamnoop
trusted call - so the codec has changed - the metadata/types need to be re-generateddata-dir
in development config is removed, to avoid directory conflict for multiple users on the same host