Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upstream commit base 922e8733 #2281

Merged
merged 25 commits into from
Nov 29, 2023
Merged

Conversation

Kailai-Wang
Copy link
Collaborator

@Kailai-Wang Kailai-Wang commented Nov 27, 2023

Context

As topic, it includes a significant amount of changes and adjustments.

Notes:

  • some adjustments in scripts are done as well
  • I see some changes in build_and_test.yml (e.g. separate worker and cli build) but I consider them less suitable for our case, so I didn't apply it to our CI
  • in pallets/teerex/src/lib.rs the block_number in confirm_processed_parentchain_block is not compact-encoded anymore - to be consistent with upstream
  • there's a new noop trusted call - so the codec has changed - the metadata/types need to be re-generated
  • data-dir in development config is removed, to avoid directory conflict for multiple users on the same host

@Kailai-Wang Kailai-Wang added the C0-breaking Breaking change that will cause existing client to break label Nov 27, 2023
@Kailai-Wang Kailai-Wang self-assigned this Nov 27, 2023
Copy link

linear bot commented Nov 27, 2023

P-283 Update upstream commit base

I see several interesting commits from upstream - I assume we want them too.

Our current code is based at b9c80164 which is 2 months ago.

Copy link
Member

@kziemianek kziemianek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I briefly checked file by file. Looks fine!

@Kailai-Wang Kailai-Wang merged commit d1c59de into dev Nov 29, 2023
24 checks passed
@Kailai-Wang Kailai-Wang deleted the p-283-update-upstream-commit-base branch November 29, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C0-breaking Breaking change that will cause existing client to break
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants