Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual tests of removing the second worker during running #2316

Merged

Conversation

kziemianek
Copy link
Member

@kziemianek kziemianek commented Dec 7, 2023

This PR adds back resuming-worker.ts to CI pipeline.
The test is moved to separate workspace because it doesn't rely on client-api (generation of that packages requires worker instance to be run).

Copy link

linear bot commented Dec 7, 2023

@kziemianek kziemianek requested review from a team, grumpygreenguy and 0xverin December 8, 2023 10:25
@Kailai-Wang
Copy link
Collaborator

The resuming-worker test is failing though, would you be able to check it?

@kziemianek
Copy link
Member Author

The resuming-worker test is failing though, would you be able to check it?

Yes @Kailai-Wang , I plan to fix it. I'll do that once I find a while.

@kziemianek kziemianek force-pushed the p-38-manual-tests-of-removing-the-second-worker-during-running branch 13 times, most recently from e1d8507 to a9f6d3e Compare January 18, 2024 13:19
@kziemianek kziemianek force-pushed the p-38-manual-tests-of-removing-the-second-worker-during-running branch 5 times, most recently from 2e1a27a to b71df92 Compare January 18, 2024 14:44
@kziemianek kziemianek force-pushed the p-38-manual-tests-of-removing-the-second-worker-during-running branch from b71df92 to d005dc5 Compare January 18, 2024 15:17
@kziemianek
Copy link
Member Author

The resuming-worker test is failing though, would you be able to check it?

@Kailai-Wang the test finally pass.

@kziemianek kziemianek requested review from a team and 0xverin January 18, 2024 16:35
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kziemianek kziemianek enabled auto-merge (squash) January 22, 2024 07:29
@kziemianek kziemianek merged commit 8969e7e into dev Jan 22, 2024
32 checks passed
@kziemianek kziemianek deleted the p-38-manual-tests-of-removing-the-second-worker-during-running branch January 22, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants